From a4a6491ca14a2b5fff3ff24db87f25d58ac2a5c9 Mon Sep 17 00:00:00 2001
From: Niels Dekker <N.Dekker@lumc.nl>
Date: Fri, 19 Aug 2022 14:18:26 +0200
Subject: [PATCH] STYLE: Use `DummyIPPPixelType = unsigned char` everywhere

Removed "todo test DummyIPPPixelType=bool", and consistently used `unsigned char` as dummy pixel type for mesh template instantiations (rather than `float` or `double`).

`DummyIPPPixelType = unsigned char` was being used on three places already.
---
 .../StatisticalShapePenalty/elxStatisticalShapePenalty.hxx    | 4 ++--
 Core/ComponentBaseClasses/elxTransformBase.hxx                | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Components/Metrics/StatisticalShapePenalty/elxStatisticalShapePenalty.hxx b/Components/Metrics/StatisticalShapePenalty/elxStatisticalShapePenalty.hxx
index c46e8fd28..047640295 100644
--- a/Components/Metrics/StatisticalShapePenalty/elxStatisticalShapePenalty.hxx
+++ b/Components/Metrics/StatisticalShapePenalty/elxStatisticalShapePenalty.hxx
@@ -351,8 +351,8 @@ StatisticalShapePenalty<TElastix>::ReadShape(const std::string &
                                              typename PointSetType::Pointer &       pointSet,
                                              const typename ImageType::ConstPointer image)
 {
-  /** Typedef's. \todo test DummyIPPPixelType=bool. */
-  using DummyIPPPixelType = double;
+  /** Typedef's. */
+  using DummyIPPPixelType = unsigned char;
   using MeshTraitsType =
     DefaultStaticMeshTraits<DummyIPPPixelType, FixedImageDimension, FixedImageDimension, CoordRepType>;
   using MeshType = Mesh<DummyIPPPixelType, FixedImageDimension, MeshTraitsType>;
diff --git a/Core/ComponentBaseClasses/elxTransformBase.hxx b/Core/ComponentBaseClasses/elxTransformBase.hxx
index 92376fc3c..f357cc48b 100644
--- a/Core/ComponentBaseClasses/elxTransformBase.hxx
+++ b/Core/ComponentBaseClasses/elxTransformBase.hxx
@@ -860,8 +860,8 @@ template <class TElastix>
 void
 TransformBase<TElastix>::TransformPointsSomePointsVTK(const std::string & filename) const
 {
-  /** Typedef's. \todo test DummyIPPPixelType=bool. */
-  using DummyIPPPixelType = float;
+  /** Typedef's. */
+  using DummyIPPPixelType = unsigned char;
   using MeshTraitsType =
     itk::DefaultStaticMeshTraits<DummyIPPPixelType, FixedImageDimension, FixedImageDimension, CoordRepType>;
   using MeshType = itk::Mesh<DummyIPPPixelType, FixedImageDimension, MeshTraitsType>;