🚀 :: v2.2.8

Author: parkuiery

.github/workflows/android-production-deploy-play-store.yml

@@ -78,6 +78,7 @@ jobs:
           tag_name: ${{ steps.get_tag.outputs.name }}
           draft: false
           prerelease: false
+          generate_release_notes: true
 
       - name: Notify Discord on Success
         if: success()

app/src/main/play/release-notes/ko-KR/default.txt

@@ -1,12 +1,12 @@
-[v2.2.7]
+[v2.2.8]
 • 자잘한 버그를 수정했어요.
 
 [ 새로운 기능 ]
 -
 
 [ 개선된 점 ]
-• 인증 화면의 버튼 디자인의 요소를 개선했어요.
+-
 
 [ 버그 수정 ]
-• 로그아웃 버그를 수정했어요.
-• 북마크에서 이동이 안되는 버그를 수정했어요.
+• 회원가입 시 비밀번호에 특수문자가 안들어가는 버그를 수정했어요.
+• 공지사항 상세화면이 안보이는 버그를 수정했어요.

buildSrc/src/main/kotlin/ProjectProperties.kt

@@ -2,8 +2,8 @@ object ProjectProperties {
     const val COMPILE_SDK = 34
     const val MIN_SDK = 28
     const val TARGET_SDK = 34
-    const val VERSION_CODE = 21
-    const val VERSION_NAME = "2.2.7"
+    const val VERSION_CODE = 22
+    const val VERSION_NAME = "2.2.8"
     const val COMPOSE_COMPILER_EXTENSION = "1.5.6"
     const val JVM_TARGET = "18"
 }

core/domain/src/main/java/team/retum/usecase/entity/notice/NoticeDetailsEntity.kt

@@ -11,7 +11,7 @@ data class NoticeDetailsEntity(
     val title: String,
     val content: String,
     val createdAt: String,
-    val attachments: List<AttachmentEntity>,
+    val attachments: List<AttachmentEntity>?,
 ) {
     data class AttachmentEntity(
         val url: String,
@@ -29,7 +29,7 @@ internal fun FetchNoticeDetailsResponse.toEntity() = NoticeDetailsEntity(
     title = this.title,
     content = this.content,
     createdAt = outputFormat.format(inputFormat.parse(this.createdAt)!!),
-    attachments = this.attachments.map { it.toEntity() },
+    attachments = this.attachments?.map { it.toEntity() },
 )
 
 private fun FetchNoticeDetailsResponse.AttachmentResponse.toEntity() =

core/network/src/main/java/team/retum/network/model/response/notice/FetchNoticeDetailsResponse.kt

@@ -9,7 +9,7 @@ data class FetchNoticeDetailsResponse(
     @Json(name = "title") val title: String,
     @Json(name = "content") val content: String,
     @Json(name = "created_at") val createdAt: String,
-    @Json(name = "attachments") val attachments: List<AttachmentResponse>,
+    @Json(name = "attachments") val attachments: List<AttachmentResponse>?,
 ) {
     @JsonClass(generateAdapter = true)
     data class AttachmentResponse(

feature/notice/src/main/java/team/retum/jobis/notice/ui/NoticeDetailsScreen.kt

@@ -119,7 +119,7 @@ private fun NoticeDetailsScreen(
                 .verticalScroll(scrollState),
         ) {
             Notice(noticeDetailsEntity = state.noticeDetailsEntity)
-            state.noticeDetailsEntity.attachments.forEach {
+            state.noticeDetailsEntity.attachments?.forEach {
                 AttachFile(
                     fileName = it.url,
                     saveFileData = saveFileData,

feature/notice/src/main/java/team/retum/jobis/notice/viewmodel/NoticeDetailsViewModel.kt

@@ -98,7 +98,7 @@ internal data class NoticeDetailsState(
                 title = "",
                 content = "",
                 createdAt = "",
-                attachments = emptyList(),
+                attachments = null,
             ),
             filePath = "",
         )

feature/signup/src/main/java/team/retum/signup/viewmodel/SetPasswordViewModel.kt

@@ -4,7 +4,7 @@ import dagger.hilt.android.lifecycle.HiltViewModel
 import team.retum.common.base.BaseViewModel
 import team.retum.common.utils.Regex
 import team.retum.jobisdesignsystemv2.textfield.DescriptionType
-import java.net.URLEncoder
+import java.util.Base64
 import java.util.regex.Pattern
 import javax.inject.Inject
 
@@ -55,7 +55,7 @@ internal class SetPasswordViewModel @Inject constructor() :
 
     internal fun onNextClick() {
         setState { state.value.copy(buttonEnabled = false) }
-        val encodedPassword = URLEncoder.encode(state.value.password, "UTF8")
+        val encodedPassword = Base64.getEncoder().encodeToString(state.value.password.toByteArray(Charsets.UTF_8))
         postSideEffect(SetPasswordSideEffect.MoveToNext(password = encodedPassword))
     }
 }

feature/signup/src/main/java/team/retum/signup/viewmodel/TermsViewModel.kt

@@ -11,6 +11,7 @@ import team.retum.signup.model.SignUpData
 import team.retum.usecase.usecase.student.PostSignUpUseCase
 import team.retum.usecase.usecase.user.GetDeviceTokenUseCase
 import java.net.URLDecoder
+import java.util.Base64
 import javax.inject.Inject
 
 @HiltViewModel
@@ -39,7 +40,7 @@ internal class TermsViewModel @Inject constructor(
 
     internal fun onCompleteClick(signUpData: SignUpData) {
         with(signUpData) {
-            val decodedPassword = URLDecoder.decode(password, "UTF8")
+            val decodedPassword = String(Base64.getDecoder().decode(password), Charsets.UTF_8)
             val decodedImageUrl = if (profileImageUrl.isNullOrEmpty()) {
                 null
             } else {