fix(Dialog): fixed update button attribute not reset opentype

jarmywang · jarmywang · commit 086dfe9bc653 · 2024-10-08T11:10:48.000+08:00
diff --git a/src/dialog/dialog.ts b/src/dialog/dialog.ts
@@ -57,6 +57,7 @@ export default class Dialog extends SuperComponent {
           class: [...cls, `${classPrefix}__button--${key}`],
           externalClass: [...externalCls, `${prefix}-class-${key}`],
           variant: rect.buttonVariant,
+          openType: '',
         };
 
         if (key === 'cancel' && rect.buttonVariant === 'base') {
@@ -95,7 +96,7 @@ export default class Dialog extends SuperComponent {
         }
       }
 
-      const hasOpenType = 'openType' in button;
+      const hasOpenType = !!button.openType;
       if (!hasOpenType && ['confirm', 'cancel'].includes(type)) {
         this[toCamel(`on-${type}`)]?.(type);
       }

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@ export default class Dialog extends SuperComponent {`
`57`	`57`	class: [...cls, `${classPrefix}__button--${key}`],
`58`	`58`	externalClass: [...externalCls, `${prefix}-class-${key}`],
`59`	`59`	`variant: rect.buttonVariant,`
	`60`	`+ openType: '',`
`60`	`61`	`};`
`61`	`62`
`62`	`63`	`if (key === 'cancel' && rect.buttonVariant === 'base') {`
`@@ -95,7 +96,7 @@ export default class Dialog extends SuperComponent {`
`95`	`96`	`}`
`96`	`97`	`}`
`97`	`98`
`98`		`- const hasOpenType = 'openType' in button;`
	`99`	`+ const hasOpenType = !!button.openType;`
`99`	`100`	`if (!hasOpenType && ['confirm', 'cancel'].includes(type)) {`
`100`	`101`	this[toCamel(`on-${type}`)]?.(type);
`101`	`102`	`}`