Fixed an issue where rendering extremely thin strokes would appear broken. #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YGaurora
requested review from
Hparty,
domchen,
kevingpqi123 and
shlzxjp
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where extremely thin strokes would appear broken or discontinuous during rendering. The fix involves treating very thin strokes as hairline strokes with alpha adjustments to simulate their appearance.
- Adds detection logic to identify strokes that are too thin after transformation and treat them as hairlines
- Implements alpha adjustment for thin strokes to maintain visual fidelity
- Refactors stroke utility functions from ApplyStrokeToBounds.h to StrokeUtils.h for better organization
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/utils/StrokeUtils.h | Adds TreatStrokeAsHairline function declaration and Matrix include |
| src/core/utils/StrokeUtils.cpp | Implements logic to detect thin strokes that should be treated as hairlines |
| src/core/StyledShape.h | Adds convertToHairlineIfNecessary method declaration |
| src/core/StyledShape.cpp | Implements hairline conversion with alpha adjustment for thin strokes |
| src/layers/ShapeLayer.cpp | Updates stroke rendering to use new thin stroke detection logic |
| src/gpu/OpsCompositor.cpp | Integrates hairline conversion into the rendering pipeline |
| include/tgfx/layers/ShapeLayer.h | Updates createStrokeShape method signature |
| include/tgfx/layers/Layer.h | Makes getGlobalMatrix method public |
| Multiple files | Updates include statements to use new StrokeUtils.h header |
| Test files | Adds regression tests for extremely thin stroke rendering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…mely_thin_stroke_broken
domchen
reviewed
Sep 18, 2025
| std::vector<Paint> strokePaints = {}; | ||
| std::shared_ptr<Shape> strokeShape = nullptr; | ||
| if (!_strokeStyles.empty()) { | ||
| bool isHairlineRender = stroke.isHairline() || TreatStrokeAsHairline(stroke, getGlobalMatrix()); |
There was a problem hiding this comment.
创建图层内容的时候不能通过getGlobalMatrix来判断，图层的矩阵是一直会变化的，而图层内容不会更新。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复渲染极度细的描边会断断续续的问题