Skip to content

Fix failed to write manifest in AGP 4.1. #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xjy2061 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix failed to write manifest in AGP 4.1. #1583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...atch-gradle-plugin/src/main/groovy/com/tencent/tinker/build/gradle/Compatibilities.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ class Compatibilities {
}

static def getOutputManifestPath(project, manifestTask, variantOutput) {
try {
return new File(manifestTask.packageManifests.get().asFile, "${variantOutput.dirName}/AndroidManifest.xml")
} catch (Throwable ignored) {
// Ignored.
}
try {
return new File(manifestTask.multiApkManifestOutputDirectory.get().asFile, "${variantOutput.dirName}/AndroidManifest.xml")
} catch (Throwable ignored) {
Expand Down Expand Up @@ -60,7 +65,10 @@ class Compatibilities {
}

static def getProcessManifestTask(project, variant) {
return project.tasks.findByName("process${variant.name.capitalize()}Manifest")
def tasks = project.tasks
def task = tasks.findByName("process${variant.name.capitalize()}ManifestForPackage")
if (task != null) return task
return tasks.findByName("process${variant.name.capitalize()}Manifest")
}

static def getMergeResourcesTask(project, variant) {
Expand Down