Merge pull request #26 from hellpirat/feature/add-scrollToWithOptions-to-window

Add scrollToWithOptions to window

Author: TheSpyder

CHANGELOG.md

@@ -4,10 +4,11 @@ Done:
 * Change all `send.pipe` externals to `send`, making them "t-first" (#16)
 * Remove deprecated APIs
 * `Window.getSelection` now returns an option, to better match the definition
+* Add scrollToWithOptions to window
 
 Todo:
 * Convert to rescript syntax
 * Convert more input types to `node_like` and `element_like` to improve usability
 * Consider switching to `namespace: true`, or otherwise improve the folder structure to avoid exposing the implementation modules
 * Correct bugs, reduce how much code is generated, add missing APIs
-* Switch this file to "keep a changelog" style or atlassian changesets
+* Switch this file to "keep a changelog" style or atlassian changesets

lib/js/tests/Webapi/Dom/Webapi__Dom__Window__test.js

@@ -72,6 +72,12 @@ window.scrollBy(10.0, -10.0);
 
 window.scrollTo(120.5, 300.3);
 
+window.scrollTo({
+      left: 1.0,
+      top: 1.0,
+      behavior: "smooth"
+    });
+
 window.stop();
 
 window.onload = (function (param) {

src/Webapi/Dom/Webapi__Dom__Window.res

@@ -130,6 +130,8 @@ module Impl = (
   @send
   external scrollTo: (t_window, float, float) => unit = "" /* experimental, CSSOM View module */
   @send external stop: t_window => unit = ""
+  
+  @send external scrollToWithOptions: (T.t, {"top": float, "left": float, "behavior": string}) => unit = "scrollTo"
 
   @send
   external addPopStateEventListener: (

tests/Webapi/Dom/Webapi__Dom__Window__test.res

@@ -71,5 +71,6 @@ let _ = window->Window.resizeTo(120, 300)
 let _ = window->Window.scroll(0.0, 0.0)
 let _ = window->Window.scrollBy(10.0, -10.0)
 let _ = window->Window.scrollTo(120.5, 300.3)
+let _ = window->Window.scrollToWithOptions({ "left": 1.0, "top": 1.0, "behavior": "smooth"})
 Window.stop(window)
 Window.setOnLoad(window, () => print_endline("load"))