Skip to content

Conversation

@kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Dec 1, 2025

ref https://github.com/TryGhost/Ghost-Release/pull/122

  • having a prefix allows our release script to ignore failed steps when deciding if commit status is green and makes status clearer for anyone viewing job status in GitHub

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

The pull request modifies the GitHub Actions CI Docker workflow file to add a conditional prefix "[Optional] " to the E2E Tests job name when the shell matrix parameter equals 'react'. This change only affects the job's display name in workflow logs and does not alter any workflow logic, execution flow, or behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward cosmetic change to a single workflow configuration file with no functional impact on the CI/CD pipeline execution.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a '[Optional]' prefix to continue-on-error CI jobs, which matches the file changes in .github/workflows/ci-docker.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description clearly relates to the changeset. It explains the reason for adding the '[Optional]' prefix to CI jobs.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-optional-prefix-to-react-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield kevinansfield requested a review from ibalosh December 1, 2025 18:27
no issue

- having a prefix allows our release script to ignore failed steps when deciding if commit status is green and makes status clearer for anyone viewing job status in GitHub
@kevinansfield kevinansfield force-pushed the add-optional-prefix-to-react-e2e branch from d50854f to 3cf1e6d Compare December 1, 2025 18:28
@kevinansfield kevinansfield changed the title Added "[Optional]" prefix to continue-on-fail CI jobs Added "[Optional]" prefix to continue-on-error CI jobs Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.00%. Comparing base (872e66b) to head (3cf1e6d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25567      +/-   ##
==========================================
- Coverage   72.00%   72.00%   -0.01%     
==========================================
  Files        1528     1528              
  Lines      117168   117168              
  Branches    13986    13986              
==========================================
- Hits        84371    84367       -4     
- Misses      31793    31795       +2     
- Partials     1004     1006       +2     
Flag Coverage Δ
admin-tests 51.71% <ø> (-0.03%) ⬇️
e2e-tests 72.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinansfield kevinansfield merged commit 95fa622 into main Dec 2, 2025
34 of 35 checks passed
@kevinansfield kevinansfield deleted the add-optional-prefix-to-react-e2e branch December 2, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants