more fixes

Author: jorgecoca

flutter_news_example/lib/ads/bloc/full_screen_ads_bloc.dart

@@ -165,8 +165,8 @@ class FullScreenAdsBloc extends Bloc<FullScreenAdsEvent, FullScreenAdsState> {
       state.interstitialAd?.fullScreenContentCallback =
           ads.FullScreenContentCallback(
             onAdDismissedFullScreenContent: (ad) => ad.dispose(),
-            onAdFailedToShowFullScreenContent: (ad, error) {
-              ad.dispose();
+            onAdFailedToShowFullScreenContent: (ad, error) async {
+              await ad.dispose();
               addError(error);
             },
           );
@@ -201,8 +201,8 @@ class FullScreenAdsBloc extends Bloc<FullScreenAdsEvent, FullScreenAdsState> {
       state.rewardedAd?.fullScreenContentCallback =
           ads.FullScreenContentCallback(
             onAdDismissedFullScreenContent: (ad) => ad.dispose(),
-            onAdFailedToShowFullScreenContent: (ad, error) {
-              ad.dispose();
+            onAdFailedToShowFullScreenContent: (ad, error) async {
+              await ad.dispose();
               addError(error);
             },
           );

flutter_news_example/lib/analytics/bloc/analytics_bloc.dart

@@ -44,8 +44,8 @@ class AnalyticsBloc extends Bloc<AnalyticsEvent, AnalyticsState> {
   }
 
   @override
-  Future<void> close() {
-    _userSubscription.cancel();
+  Future<void> close() async {
+    await _userSubscription.cancel();
     return super.close();
   }
 }

flutter_news_example/lib/app/bloc/app_bloc.dart

@@ -106,8 +106,8 @@ class AppBloc extends Bloc<AppEvent, AppState> {
   }
 
   @override
-  Future<void> close() {
-    _userSubscription.cancel();
+  Future<void> close() async {
+    await _userSubscription.cancel();
     return super.close();
   }
 }

flutter_news_example/lib/login/bloc/login_with_email_link_bloc.dart

@@ -70,8 +70,8 @@ class LoginWithEmailLinkBloc
   }
 
   @override
-  Future<void> close() {
-    _incomingEmailLinksSub.cancel();
+  Future<void> close() async {
+    await _incomingEmailLinksSub.cancel();
     return super.close();
   }
 }

flutter_news_example/lib/subscriptions/dialog/bloc/subscriptions_bloc.dart

@@ -74,8 +74,8 @@ class SubscriptionsBloc extends Bloc<SubscriptionsEvent, SubscriptionsState> {
   }
 
   @override
-  Future<void> close() {
-    _subscriptionPurchaseUpdateSubscription.cancel();
+  Future<void> close() async {
+    await _subscriptionPurchaseUpdateSubscription.cancel();
     return super.close();
   }
 }

flutter_news_example/lib/subscriptions/view/manage_subscription_page.dart

@@ -57,10 +57,10 @@ class ManageSubscriptionView extends StatelessWidget {
                     color: AppColors.darkAqua,
                   ),
                 ),
-                onTap: () {
+                onTap: () async {
                   // No possibility to revoke subscriptions from the app.
                   // Navigate the user to "Manage Subscriptions" page instead.
-                  Navigator.maybePop(context);
+                  await Navigator.maybePop(context);
                 },
               ),
             ],

flutter_news_example/lib/user_profile/bloc/user_profile_bloc.dart

@@ -99,8 +99,8 @@ class UserProfileBloc extends Bloc<UserProfileEvent, UserProfileState> {
   }
 
   @override
-  Future<void> close() {
-    _userSubscription.cancel();
+  Future<void> close() async {
+    await _userSubscription.cancel();
     return super.close();
   }
 }

flutter_news_example/lib/user_profile/view/user_profile_page.dart

@@ -176,8 +176,8 @@ class _UserProfileViewState extends State<UserProfileView>
                     Align(
                       child: AppButton.smallTransparent(
                         key: const Key('userProfilePage_deleteAccountButton'),
-                        onPressed: () {
-                          showDialog<void>(
+                        onPressed: () async {
+                          await showDialog<void>(
                             context: context,
                             builder: (_) =>
                                 const UserProfileDeleteAccountDialog(),

flutter_news_example/packages/analytics_repository/test/analytics_repository_test.dart

@@ -31,13 +31,13 @@ void main() {
     });
 
     group('track', () {
-      test('tracks event successfully', () {
+      test('tracks event successfully', () async {
         const event = AnalyticsEvent(
           'TestEvent',
           properties: <String, String>{'test-key': 'mock-id'},
         );
 
-        analyticsRepository.track(event);
+        await analyticsRepository.track(event);
 
         verify(
           () => firebaseAnalytics.logEvent(
@@ -72,10 +72,10 @@ void main() {
     });
 
     group('setUserId', () {
-      test('sets user identifier successfully', () {
+      test('sets user identifier successfully', () async {
         const userId = 'userId';
 
-        analyticsRepository.setUserId(userId);
+        await analyticsRepository.setUserId(userId);
 
         verify(() => firebaseAnalytics.setUserId(id: userId)).called(1);
       });

flutter_news_example/packages/deep_link_client/firebase_deep_link_client/test/firebase_deep_link_client_test.dart

@@ -20,8 +20,8 @@ void main() {
     ).thenAnswer((_) => onLinkStreamController.stream);
   });
 
-  tearDown(() {
-    onLinkStreamController.close();
+  tearDown(() async {
+    await onLinkStreamController.close();
   });
 
   group('FirebaseDeepLinkClient', () {