Merge pull request #2355 from ViewComponent/v4-warnings

Resolve remaining warnings when running tests

Author: joelhawksley

.github/workflows/ci.yml

@@ -48,7 +48,7 @@ jobs:
         bundler-cache: true
     - name: Build and test with Rake
       run: |
-        bundle exec appraisal rails-${{ matrix.rails_version }} bundle
+        bundle exec appraisal rails-${{ matrix.rails_version }} bundle --quiet
         MEASURE_COVERAGE=true bundle exec appraisal rails-${{ matrix.rails_version }} rake
       env:
         RAISE_ON_WARNING: 1
@@ -89,7 +89,7 @@ jobs:
         cd primer_view_components
         npm ci
         cd demo && npm ci && cd ..
-        bundle && bundle exec rake
+        bundle --quiet && bundle exec rake
       env:
         VIEW_COMPONENT_PATH: ../view_component
         RAILS_VERSION: '7.1.5'

Rakefile

@@ -17,12 +17,6 @@ Rake::TestTask.new(:engine_test) do |t|
   t.test_files = FileList["test/test_engine/**/*_test.rb"]
 end
 
-Rake::TestTask.new(:docs_test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/docs/*_test.rb"]
-end
-
 begin
   require "rspec/core/rake_task"
   RSpec::Core::RakeTask.new(:spec)
@@ -60,18 +54,13 @@ namespace :coverage do
 end
 
 namespace :docs do
-  # Build api.md documentation page from YARD comments.
   task :build do
     YARD::Rake::YardocTask.new do |t|
-      t.options = ["--no-output"]
+      t.options = ["--no-output", "-q"]
     end
 
-    puts "Building YARD documentation."
-
     Rake::Task["yard"].execute
 
-    puts "Converting YARD documentation to Markdown files."
-
     registry = YARD::RegistryStore.new
     registry.load!(".yardoc")
 
@@ -141,4 +130,4 @@ namespace :docs do
   end
 end
 
-task default: [:docs_test, :test, :engine_test, :spec]
+task default: [:test, :engine_test, :spec]

test/sandbox/app/components/conditional_content_with_arg_component.rb

@@ -6,7 +6,7 @@ def initialize(description: nil)
   end
 
   def call
-    description
+    description&.html_safe
   end
 
   private

test/sandbox/app/components/request_param_component.rb

@@ -4,6 +4,6 @@ def initialize(request:)
   end
 
   def call
-    @request
+    @request.html_safe
   end
 end

test/sandbox/config/application.rb

@@ -37,6 +37,8 @@
 
 module Sandbox
   class Application < Rails::Application
+    config.load_defaults(8.1) if Rails::VERSION::MAJOR == 8 && Rails::VERSION::MINOR == 1
+
     config.action_controller.asset_host = "http://assets.example.com"
 
     # Prepare test_set_no_duplicate_autoload_paths

test/sandbox/config/environments/test.rb

@@ -4,10 +4,12 @@
 
 # Use https://github.com/jeremyevans/ruby-warning
 # to restrict warnings outside our control
-["mail", "activesupport", "yard"].each do |gem_name|
+["mail", "activesupport", "yard", "capybara"].each do |gem_name|
   Warning.ignore(//, /.*gems\/#{gem_name}-.*/)
 end
 
+Warning.ignore(/warning: parser\/current/)
+
 Sandbox::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

test/sandbox/test/config_test.rb

@@ -20,7 +20,7 @@ def test_all_methods_are_documented
       require "yard"
       require "rake"
       YARD::Rake::YardocTask.new do |t|
-        t.options = ["--no-output", "--no-stats", "--no-progress"]
+        t.options = ["--no-output", "--no-stats", "--no-progress", "-q"]
       end
       Rake::Task["yard"].execute
       configuration_methods_to_document = YARD::RegistryStore.new.tap do |store|

test/sandbox/test/rendering_test.rb

@@ -1253,7 +1253,7 @@ def call
       #
       #   hi # raises: undefined method `hi' for #<GreetingComponent....
       #
-      helpers.hi
+      helpers.hi.html_safe
     end
   end