VCST-4203: Remove obsolete code (#2963)

Author: artem-dudarev

src/VirtoCommerce.Platform.Core/Bus/IHandlerRegistrar.cs

@@ -5,11 +5,10 @@
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
 using VirtoCommerce.Platform.Core.Events;
-using VirtoCommerce.Platform.Core.Messages;
 
 namespace VirtoCommerce.Platform.Core.Bus
 {
-    public class InProcessBus : IEventHandlerRegistrar, IEventPublisher, IHandlerRegistrar
+    public class InProcessBus : IEventHandlerRegistrar, IEventPublisher
     {
         private readonly ILogger<InProcessBus> _logger;
         private readonly List<HandlerWrapper> _handlers = [];
@@ -19,47 +18,6 @@ public InProcessBus(ILogger<InProcessBus> logger)
             _logger = logger;
         }
 
-        [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-        public void RegisterEventHandler<T>(Func<T, Task> handler)
-            where T : IEvent
-        {
-            var eventType = typeof(T);
-
-            var handlerWrapper = new HandlerWrapper
-            {
-                EventType = eventType,
-                HandlerModuleName = handler.Target?.GetType().Module.Assembly.GetName().Name,
-                Handler = (message, _) => handler((T)message),
-                Logger = _logger
-            };
-
-            _handlers.Add(handlerWrapper);
-        }
-
-        [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-        public void RegisterEventHandler<T>(Func<T, CancellationToken, Task> handler)
-            where T : IEvent
-        {
-            RegisterHandler(handler);
-        }
-
-        [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-        public void RegisterHandler<T>(Func<T, CancellationToken, Task> handler)
-            where T : IMessage
-        {
-            var eventType = typeof(T);
-
-            var handlerWrapper = new HandlerWrapper
-            {
-                EventType = eventType,
-                HandlerModuleName = handler.Target?.GetType().Module.Assembly.GetName().Name,
-                Handler = (message, token) => handler((T)message, token),
-                Logger = _logger
-            };
-
-            _handlers.Add(handlerWrapper);
-        }
-
         public void RegisterEventHandler<T>(IEventHandler<T> handler)
             where T : IEvent
         {

src/VirtoCommerce.Platform.Core/Bus/InProcessBus.cs

@@ -41,12 +41,6 @@ public static AsyncLock GetLockByKey(string key)
             return new AsyncLock(key);
         }
 
-        [Obsolete("Use LockAsync()", DiagnosticId = "VC0009", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-        public Task<IDisposable> GetReleaserAsync()
-        {
-            return LockAsync();
-        }
-
         public async Task<IDisposable> LockAsync()
         {
             await GetOrCreate(_key).WaitAsync().ConfigureAwait(false);

src/VirtoCommerce.Platform.Core/Common/AsyncLock.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
 
@@ -18,15 +15,6 @@ public static IApplicationBuilder RegisterEventHandler<TEvent, THandler>(this IA
         return applicationBuilder;
     }
 
-    [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-    public static IApplicationBuilder RegisterEventHandler<TEvent>(this IApplicationBuilder applicationBuilder, Func<TEvent, Task> handler)
-        where TEvent : IEvent
-    {
-        var registrar = applicationBuilder.ApplicationServices.GetRequiredService<IEventHandlerRegistrar>();
-        registrar.RegisterEventHandler(handler);
-        return applicationBuilder;
-    }
-
     public static IApplicationBuilder RegisterCancellableEventHandler<TEvent, THandler>(this IApplicationBuilder applicationBuilder)
         where TEvent : IEvent
         where THandler : ICancellableEventHandler<TEvent>
@@ -37,15 +25,6 @@ public static IApplicationBuilder RegisterCancellableEventHandler<TEvent, THandl
         return applicationBuilder;
     }
 
-    [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-    public static IApplicationBuilder RegisterCancellableEventHandler<TEvent>(this IApplicationBuilder applicationBuilder, Func<TEvent, CancellationToken, Task> handler)
-        where TEvent : IEvent
-    {
-        var registrar = applicationBuilder.ApplicationServices.GetRequiredService<IEventHandlerRegistrar>();
-        registrar.RegisterEventHandler(handler);
-        return applicationBuilder;
-    }
-
     public static IApplicationBuilder UnregisterEventHandler<TEvent, THandler>(this IApplicationBuilder applicationBuilder)
         where TEvent : IEvent
         where THandler : IEventHandler<TEvent>

src/VirtoCommerce.Platform.Core/Events/ApplicationBuilderExtensions.cs

@@ -38,9 +38,6 @@ private void Dispose(bool disposing)
         /// </summary>
         public static bool EventsSuppressed => _eventsSuppressedStorage.Value;
 
-        [Obsolete("Use SuppressEvents()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions/")]
-        public static IDisposable SupressEvents() => SuppressEvents();
-
         /// <summary>
         /// The flag indicates that events are suppressed for the current asynchronous control flow
         /// </summary>

src/VirtoCommerce.Platform.Core/Events/EventSuppressor.cs

@@ -1,17 +1,9 @@
 using System;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace VirtoCommerce.Platform.Core.Events;
 
 public interface IEventHandlerRegistrar
 {
-    [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-    void RegisterEventHandler<T>(Func<T, Task> handler) where T : IEvent;
-
-    [Obsolete("Use IApplicationBuilder.RegisterEventHandler<TEvent, THandler>()", DiagnosticId = "VC0008", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-    void RegisterEventHandler<T>(Func<T, CancellationToken, Task> handler) where T : IEvent;
-
     void RegisterEventHandler<T>(IEventHandler<T> handler) where T : IEvent;
     void RegisterEventHandler<T>(ICancellableEventHandler<T> handler) where T : IEvent;
 

src/VirtoCommerce.Platform.Core/Events/IEventHandlerRegistrar.cs

@@ -38,7 +38,6 @@ public static IServiceCollection AddPlatformServices(this IServiceCollection ser
 
             services.AddSingleton<InProcessBus>();
             services.AddSingleton<IEventHandlerRegistrar>(x => x.GetRequiredService<InProcessBus>());
-            services.AddSingleton<IHandlerRegistrar>(x => x.GetRequiredService<InProcessBus>());
             services.AddSingleton<IEventPublisher>(x => x.GetRequiredService<InProcessBus>());
             services.AddTransient<IChangeLogService, ChangeLogService>();
             services.AddTransient<ILastModifiedDateTime, ChangeLogService>();

src/VirtoCommerce.Platform.Core/Security/IExternalSigninService.cs

@@ -9,9 +9,6 @@ namespace VirtoCommerce.Platform.Data.Repositories
 {
     public class PlatformDbContext : DbContextBase
     {
-        [Obsolete("Use Length128 or IdLength", DiagnosticId = "VC0009", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
-        protected const int _idLength128 = 128;
-
         [Obsolete("Use Length64 or UserNameLength", DiagnosticId = "VC0010", UrlFormat = "https://docs.virtocommerce.org/products/products-virto3-versions")]
         protected const int _idLength64 = 64;