feat: add line and column to error and warnings

The line and column is  taken from the first label with the same level as the report. For error reports is the first error label, and for warning reports is the first warning label.

Author: plusvic

go/compiler.go

@@ -138,6 +138,10 @@ type CompileError struct {
 	Code string `json:"code"`
 	// Error title (e.g: "unknown identifier `foo`").
 	Title string `json:"title"`
+	// Error line number. This is the line number of the first error label.
+	Line int `json:"line"`
+	// Error column number. This is the column number of the first error label.
+	Column int `json:"column"`
 	// Each of the labels in the error report.
 	Labels []Label `json:"labels,omitempty"`
 	// Each of the footers in the error report.
@@ -148,10 +152,14 @@ type CompileError struct {
 
 // Warning represents each of the warnings returned by [Compiler.Warnings].
 type Warning struct {
-	// Error code (e.g: "slow_pattern").
+	// Warning code (e.g: "slow_pattern").
 	Code string `json:"code"`
-	// Error title (e.g: "slow pattern").
+	// Warning title (e.g: "slow pattern").
 	Title string `json:"title"`
+	// Warning line number. This is the line number of the first warning label.
+	Line int `json:"line"`
+	// Warning column number. This is the column number of the first warning label.
+	Column int `json:"column"`
 	// Each of the labels in the warning report.
 	Labels []Label `json:"labels,omitempty"`
 	// Each of the footers in the warning report.

go/compiler_test.go

@@ -163,8 +163,10 @@ func TestErrors(t *testing.T) {
 
 	assert.Equal(t, []Warning{
 		{
-			Code:  "invariant_expr",
-			Title: "invariant boolean expression",
+			Code:   "invariant_expr",
+			Title:  "invariant boolean expression",
+			Line:   1,
+			Column: 26,
 			Labels: []Label{
 				{
 					Level:  "warning",
@@ -193,8 +195,10 @@ func TestErrors(t *testing.T) {
 	c.AddSource("rule test_2 { condition: foo }", WithOrigin("test.yar"))
 	assert.Equal(t, []CompileError{
 		{
-			Code:  "E009",
-			Title: "unknown identifier `foo`",
+			Code:   "E009",
+			Title:  "unknown identifier `foo`",
+			Line:   1,
+			Column: 26,
 			Labels: []Label{
 				{
 					Level:      "error",
@@ -293,8 +297,10 @@ func TestWarnings(t *testing.T) {
 
 	assert.Equal(t, []Warning{
 		{
-			Code:  "consecutive_jumps",
-			Title: "consecutive jumps in hex pattern `$a`",
+			Code:   "consecutive_jumps",
+			Title:  "consecutive jumps in hex pattern `$a`",
+			Line:   1,
+			Column: 31,
 			Labels: []Label{
 				{
 					Level:      "warning",
@@ -314,8 +320,10 @@ func TestWarnings(t *testing.T) {
   |`,
 		},
 		{
-			Code:  "slow_pattern",
-			Title: "slow pattern",
+			Code:   "slow_pattern",
+			Title:  "slow pattern",
+			Line:   1,
+			Column: 22,
 			Labels: []Label{
 				{
 					Level:      "warning",

lib/src/compiler/report.rs

@@ -149,11 +149,27 @@ impl Serialize for Report {
     where
         S: Serializer,
     {
+        let labels = self.labels().collect::<Vec<_>>();
+        let footers = &self.footers().collect::<Vec<_>>();
+
         let mut s = serializer.serialize_struct("report", 4)?;
+
         s.serialize_field("code", &self.code)?;
         s.serialize_field("title", &self.title)?;
-        s.serialize_field("labels", &self.labels().collect::<Vec<_>>())?;
-        s.serialize_field("footers", &self.footers().collect::<Vec<_>>())?;
+
+        // Find the first label with the same level as the report itself.
+        // The report's line and column will be the line and column of
+        // that label.
+        if let Some(label) = labels
+            .iter()
+            .find(|label| label.level == level_as_text(self.level))
+        {
+            s.serialize_field("line", &label.line)?;
+            s.serialize_field("column", &label.column)?;
+        }
+
+        s.serialize_field("labels", &labels)?;
+        s.serialize_field("footers", &footers)?;
         s.serialize_field("text", &self.to_string())?;
         s.end()
     }