style: fix clippy warnings.

Author: plusvic

cli/src/commands/check.rs

@@ -5,7 +5,6 @@ use std::{fs, io};
 use anyhow::Context;
 use clap::{arg, value_parser, ArgAction, ArgMatches, Command};
 use crossterm::tty::IsTty;
-use regex;
 use superconsole::{Component, Line, Lines, Span};
 use yansi::Color::{Green, Red, Yellow};
 use yansi::Paint;
@@ -115,7 +114,7 @@ pub fn exec_check(args: &ArgMatches, config: &Config) -> anyhow::Result<()> {
                     MetaValueType::String => {
                         let message = if let Some(regexp) = &config.regexp {
                             // Make sure that the regexp is valid.
-                            let _ = regex::bytes::Regex::new(&regexp)?;
+                            let _ = regex::bytes::Regex::new(regexp)?;
                             format!("`{identifier}` must be a string that matches `/{regexp}/`")
                         } else {
                             format!("`{identifier}` must be a string")
@@ -124,10 +123,10 @@ pub fn exec_check(args: &ArgMatches, config: &Config) -> anyhow::Result<()> {
                             |meta| {
                                 match (&meta.value, &config.regexp) {
                                     (MetaValue::String((s, _)), Some(regexp)) => {
-                                        regex::Regex::new(&regexp).unwrap().is_match(s)
+                                        regex::Regex::new(regexp).unwrap().is_match(s)
                                     }
                                     (MetaValue::Bytes((s, _)), Some(regexp)) => {
-                                        regex::bytes::Regex::new(&regexp).unwrap().is_match(s)
+                                        regex::bytes::Regex::new(regexp).unwrap().is_match(s)
                                     }
                                     (MetaValue::String(_), None) => true,
                                     (MetaValue::Bytes(_), None) => true,

lib/src/compiler/report.rs

@@ -524,7 +524,7 @@ fn level_as_text(level: &Level) -> &'static str {
         Level::INFO => "info",
         Level::NOTE => "note",
         Level::HELP => "help",
-        _ => panic!("unsupported level {:?}", level),
+        _ => panic!("unsupported level {level:?}"),
     }
 }
 

lib/src/modules/pe/parser.rs

@@ -1914,8 +1914,7 @@ impl<'a> PE<'a> {
                     if let Ok(rva) = TryInto::<u32>::try_into(thunk) {
                         func.name = self
                             .parse_at_rva(rva, Self::parse_import_by_name)
-                            .and_then(|s| str::from_utf8(s).ok())
-                            .map(|s| s.to_string());
+                            .and_then(|s| String::from_utf8(s.to_vec()).ok())
                     }
                 }