Skip to content

Commit 743ff1e

Browse files
authored
Merge pull request #1493 from WalletConnect/remove_qr_lib
Remove faulty qr code dependency
2 parents de3b6fc + de9b95c commit 743ff1e

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

sample/dapp/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ dependencies {
7878

7979
implementation("io.insert-koin:koin-androidx-compose:3.4.3")
8080
implementation("io.coil-kt:coil-compose:2.3.0")
81-
implementation("androidmads.library.qrgenearator:QRGenearator:1.0.4")
8281

82+
implementation(libs.qrCodeGenerator)
8383
implementation(platform(libs.androidx.compose.bom))
8484
implementation(libs.androidx.compose.ui)
8585
implementation(libs.androidx.compose.ui.tooling.preview)

sample/dapp/src/main/kotlin/com/walletconnect/sample/dapp/ui/routes/composable_routes/chain_selection/ChainSelectionRoute.kt

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@ package com.walletconnect.sample.dapp.ui.routes.composable_routes.chain_selectio
33
import android.content.Context
44
import android.widget.Toast
55
import android.content.Intent
6-
import android.graphics.Bitmap
7-
import android.net.Uri
8-
import androidmads.library.qrgenearator.QRGContents
9-
import androidmads.library.qrgenearator.QRGEncoder
6+
import android.graphics.drawable.Drawable
107
import java.net.URLEncoder
118
import androidx.compose.foundation.Image
129
import androidx.compose.foundation.background
@@ -61,7 +58,11 @@ import androidx.compose.ui.unit.sp
6158
import androidx.compose.ui.window.Dialog
6259
import androidx.lifecycle.viewmodel.compose.viewModel
6360
import androidx.navigation.NavController
61+
import com.github.alexzhirkevich.customqrgenerator.QrData
62+
import com.github.alexzhirkevich.customqrgenerator.vector.QrCodeDrawable
63+
import com.google.accompanist.drawablepainter.rememberDrawablePainter
6464
import com.walletconnect.android.utils.isPackageInstalled
65+
import com.walletconnect.modalcore.R
6566
import com.walletconnect.sample.common.Chains
6667
import com.walletconnect.sample.common.CompletePreviews
6768
import com.walletconnect.sample.common.ui.WCTopAppBarLegacy
@@ -74,15 +75,12 @@ import com.walletconnect.sample.common.ui.toColor
7475
import com.walletconnect.sample.dapp.BuildConfig
7576
import com.walletconnect.sample.dapp.ui.DappSampleEvents
7677
import com.walletconnect.sample.dapp.ui.routes.Route
77-
import com.walletconnect.sign.client.Sign
78-
import com.walletconnect.wcmodal.client.Modal
7978
import com.walletconnect.wcmodal.client.WalletConnectModal
8079
import com.walletconnect.wcmodal.ui.openWalletConnectModal
8180
import com.walletconnect.wcmodal.ui.state.rememberModalState
8281
import kotlinx.coroutines.CoroutineDispatcher
8382
import kotlinx.coroutines.CoroutineScope
8483
import kotlinx.coroutines.Dispatchers
85-
import kotlinx.coroutines.flow.collectLatest
8684
import kotlinx.coroutines.launch
8785

8886
@Composable
@@ -330,7 +328,7 @@ private fun ChainSelectionScreen(
330328

331329
@Composable
332330
private fun QRDialog(composableScope: CoroutineScope, dispatcher: CoroutineDispatcher, pairingUri: PairingUri, onDismissRequest: () -> Unit, context: Context) {
333-
val qrBitmap = generateQRCode(pairingUri.uri)
331+
val qrDrawable = generateQRCode(pairingUri.uri)
334332
val clipboardManager: ClipboardManager = LocalClipboardManager.current
335333

336334
Dialog(onDismissRequest = { onDismissRequest() }) {
@@ -342,9 +340,9 @@ private fun QRDialog(composableScope: CoroutineScope, dispatcher: CoroutineDispa
342340
contentAlignment = Alignment.Center
343341
) {
344342
Column(horizontalAlignment = Alignment.CenterHorizontally) {
345-
qrBitmap?.let {
343+
qrDrawable?.let {
346344
Image(
347-
bitmap = it.asImageBitmap(),
345+
painter = rememberDrawablePainter(drawable = it),
348346
contentDescription = "QR Code",
349347
modifier = Modifier
350348
.fillMaxWidth()
@@ -447,10 +445,10 @@ private fun onDynamicSwitcher(
447445
}
448446
}
449447

450-
fun generateQRCode(content: String): Bitmap? {
451-
val qrgEncoder = QRGEncoder(content, null, QRGContents.Type.TEXT, 400)
448+
fun generateQRCode(content: String): Drawable? {
449+
val qrgEncoder = QrCodeDrawable(QrData.Url(content))
452450
return try {
453-
qrgEncoder.bitmap
451+
qrgEncoder
454452
} catch (e: Exception) {
455453
e.printStackTrace()
456454
null

0 commit comments

Comments
 (0)