Skip to content

Commit a7be8e1

Browse files
committed
[CI] Test on oldest supported Ubuntu version as well as latest. NFC
This ensures we don't break the emsdk builder which builds binaryen on a pinned/older version of Ubuntu (currently 20.24 / Focal).
1 parent 95b2cf0 commit a7be8e1

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ jobs:
5151
runs-on: ${{ matrix.os }}
5252
strategy:
5353
matrix:
54-
os: [ubuntu-latest, macos-latest, windows-latest, windows-11-arm]
54+
# Test on the oldest support Ubuntu version in addition to `latest`.
55+
os: [ubuntu-20.04, ubuntu-latest, macos-latest, windows-latest, windows-11-arm]
5556
steps:
5657
- uses: actions/setup-python@v5
5758
with:
@@ -65,11 +66,11 @@ jobs:
6566

6667
- name: gen-s-parser
6768
run: ./scripts/gen-s-parser.py | diff src/gen-s-parser.inc -
68-
if: matrix.os == 'ubuntu-latest'
69+
if: startsWith(matrix.os, 'ubuntu')
6970

7071
- name: install ninja (linux)
7172
run: sudo apt-get install ninja-build
72-
if: matrix.os == 'ubuntu-latest'
73+
if: startsWith(matrix.os, 'ubuntu')
7374

7475
- name: install ninja (macos)
7576
run: brew install ninja
@@ -89,7 +90,7 @@ jobs:
8990

9091
- name: cmake (linux)
9192
run: cmake -S . -B out -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=out/install
92-
if: matrix.os == 'ubuntu-latest'
93+
if: startsWith(matrix.os, 'ubuntu')
9394

9495
- name: cmake (macos)
9596
run: cmake -S . -B out -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=out/install '-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64'

0 commit comments

Comments
 (0)