Skip to content

Commit 1227cdc

Browse files
committed
add some test
1 parent c9d8edb commit 1227cdc

File tree

14 files changed

+606
-40
lines changed

14 files changed

+606
-40
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.pub
22
packages
33
.packages
4+
.dart_tool
45

56
example/.pub
67
example/packages

example/lib/reducers/app_state.g.dart

Lines changed: 4 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/lib/reducers/group.g.dart

Lines changed: 5 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/lib/reducers/groups.g.dart

Lines changed: 4 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/generator.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ generateActions(ClassElement element) {
3434
if (ele is ClassElement && typeName == 'ActionMgr') {
3535
nameCode = nameCode.replaceFirst(
3636
'\n',
37-
'\nstatic ActionName $fieldName = new ActionName<${_getActionMgrGenericType(e)}>(\'$fieldName\');\n',
37+
'\nstatic ActionName $fieldName = new ActionName<${_getActionMgrGenericType(e)}>(\'${element.name}-$fieldName\');\n',
3838
);
3939

4040
var actionMgr =
41-
'\n${e.toString()} = new ActionMgr<${_getActionMgrGenericType(e)}>(\'$fieldName\');\n';
41+
'\n${e.toString()} = new ActionMgr<${_getActionMgrGenericType(e)}>(\'${element.name}-$fieldName\');\n';
4242
if (!actionMgr.startsWith('\nfinal')) actionMgr = '\nfinal $actionMgr';
4343
initializerCode = initializerCode.replaceFirst('\n', actionMgr);
4444
syncWithStoreCode =

lib/src/store.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ class Store<State extends BuiltReducer, Actions extends ReduxActions> {
5252
_dispatch.stream.listen(handler);
5353
}
5454

55+
dispose() {
56+
_stateController.close();
57+
_dispatch.close();
58+
}
59+
5560
/// [subscribe] returns a stream that will be dispatched whenever the state changes
5661
Stream<State> get subscribe => _stateController.stream;
5762

lib/transformer.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'package:analyzer/analyzer.dart';
33
import 'package:path/path.dart' as p;
44
import 'package:source_span/source_span.dart';
55
import 'package:transformer_utils/transformer_utils.dart';
6-
76
import 'dart:async';
87
import 'dart:io';
98

@@ -49,6 +48,7 @@ class BuiltStoreTransformer extends Transformer {
4948
name: transform.primaryInput.id.path,
5049
parseFunctionBodies: false,
5150
);
51+
5252
for (CompilationUnitMember d in unit.declarations) {
5353
if (d is! ClassDeclaration) continue;
5454
var cd = d as ClassDeclaration;
@@ -58,7 +58,7 @@ class BuiltStoreTransformer extends Transformer {
5858
var name = superclass.name.name;
5959
if (name == 'BuiltReducer') {
6060
String reduceChildrenBody =
61-
"\n\n @override\n reduceChildren(dynamic state, Action<dynamic> a, dynamic builder) {\n }";
61+
"\n\n @override\n reduceChildren(dynamic state, Action<dynamic> a, dynamic builder) {\n }";
6262

6363
for (ClassMember m in cd.members) {
6464
if (m is! MethodDeclaration) continue;
@@ -90,8 +90,10 @@ class BuiltStoreTransformer extends Transformer {
9090
Iterable<String> getBuiltReducers() {
9191
var builtReducers = ['BuiltReducer'];
9292

93-
Directory base = new Directory(p.url.join(Directory.current.path, 'lib'));
94-
var files = base.listSync(recursive: true);
93+
Directory libBase = new Directory(p.url.join(Directory.current.path, 'lib'));
94+
var files = libBase.listSync(recursive: true);
95+
Directory testBase = new Directory(p.url.join(Directory.current.path, 'test'));
96+
files.addAll(testBase.listSync(recursive: true));
9597
for (var f in files) {
9698
if (f is! File) continue;
9799

0 commit comments

Comments
 (0)