Merge pull request #42 from bwu-dart-contributing/dispose_wait_for_close

`store.dispose()` should wait for `_stateController.close()` to complete

Author: davidmarne

lib/src/store.dart

@@ -66,8 +66,8 @@ class Store<
   }
 
   /// [dispose] removes closes both the dispatch and subscription stream
-  void dispose() {
-    _stateController.close();
+  Future<Null> dispose() async {
+    await _stateController.close();
     _state = null;
     _actions = null;
   }

test/unit/store_test.dart

@@ -35,17 +35,17 @@ void main() {
       final onStateChangeCompleter = new Completer<
           StoreChange<BaseCounter, BaseCounterBuilder, dynamic>>();
 
-      final storeChagneHandler = createChangeHandler(onStateChangeCompleter);
-      storeChagneHandler.build(store);
-      // dipatch 2 different actions, since the handler is only set to listen to base.increment
+      final storeChangeHandler = createChangeHandler(onStateChangeCompleter);
+      storeChangeHandler.build(store);
+      // dispatch 2 different actions, since the handler is only set to listen to base.increment
       // if both are handled by the handler the completer with throw an error
       store.actions.decrement(1);
       store.actions.increment(4);
 
       final stateChange = await onStateChangeCompleter.future;
       expect(stateChange.prev.count, 0);
       expect(stateChange.next.count, 4);
-      storeChagneHandler.dispose();
+      storeChangeHandler.dispose();
     });
 
     test('replaceState', () async {
@@ -119,5 +119,16 @@ void main() {
       expect(stateChange.next.count, 3);
       expect(stateChange.action.payload, 2);
     });
+
+    test('should not reset state and actions before closing', () async {
+      store
+          .substateStream((s) => s)
+          .listen((_) => expect(store.actions, isNotNull));
+
+      // intentionally don't wait
+      store.dispose();
+
+      store.actions.increment(1);
+    });
   });
 }