Skip to content

Commit 9d6e59a

Browse files
fixed incorrect range calculation
1 parent 3f184fd commit 9d6e59a

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Changelog
22

33
## Unreleased
4-
- Added support for `enclosing_range` on symbol occurrences
4+
- Added support for `enclosing_range` on occurrences definitions
55

66
## 1.6.2
77
- Fixed a few minor bugs found in pubspec.yaml indexing (skips publish_to: none pubspecs, and considers "version" optional)

lib/src/scip_visitor.dart

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -132,22 +132,22 @@ class ScipVisitor extends GeneralizingAstVisitor {
132132
if (symbol != null) {
133133
final meta = getSymbolMetadata(element, offset, _analysisErrors);
134134
occurrences.add(Occurrence(
135-
range: _lineInfo.getRange(offset, length),
136-
symbol: symbol,
137-
diagnostics: meta.diagnostics,
138-
enclosingRange:
139-
_lineInfo.getRange(node.parent!.offset, node.parent!.length)));
135+
range: _lineInfo.getRange(offset, length),
136+
symbol: symbol,
137+
diagnostics: meta.diagnostics,
138+
));
140139

141140
if (!element.source!.fullName.startsWith(_projectRoot)) {
142141
if (!globalExternalSymbols.any(
143142
(symbolInfo) => symbolInfo.symbol == symbol,
144143
)) {
145144
final meta = getSymbolMetadata(element, offset, _analysisErrors);
146145
globalExternalSymbols.add(SymbolInformation(
147-
symbol: symbol,
148-
documentation: meta.documentation,
149-
signatureDocumentation: meta.signatureDocumentation,
150-
kind: symbolKindFor(element)));
146+
symbol: symbol,
147+
documentation: meta.documentation,
148+
signatureDocumentation: meta.signatureDocumentation,
149+
kind: symbolKindFor(element),
150+
));
151151
}
152152
}
153153
}
@@ -176,11 +176,11 @@ class ScipVisitor extends GeneralizingAstVisitor {
176176
));
177177

178178
occurrences.add(Occurrence(
179-
range: _lineInfo.getRange(element.nameOffset, element.nameLength),
180-
symbol: symbol,
181-
symbolRoles: SymbolRole.Definition.value,
182-
diagnostics: meta.diagnostics,
183-
enclosingRange:
184-
_lineInfo.getRange(node.parent!.offset, node.parent!.length)));
179+
range: _lineInfo.getRange(element.nameOffset, element.nameLength),
180+
symbol: symbol,
181+
symbolRoles: SymbolRole.Definition.value,
182+
diagnostics: meta.diagnostics,
183+
enclosingRange: _lineInfo.getRange(node.offset, node.end),
184+
));
185185
}
186186
}

0 commit comments

Comments
 (0)