feat: --output flag #169
feat: --output flag #169
Conversation
matthewnitschke-wk
left a comment
matthewnitschke-wk
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I like the general idea, and the ability to specify output location, just have 2 small questions
| help: | ||
| 'The output file to write the index to. Use "-" to write to stdout', |
There was a problem hiding this comment.
Do you have a use case for outputting to stdout? given the potential size and usage of these files, I'm curious how this might be used?
There was a problem hiding this comment.
We use SCIP internally for some stuff, and we sometimes have to save to a file just to read it straight back in to parse it. This way we can skip the write to disk
bin/scip_dart.dart
Outdated
| final index = await indexPackage(packageRoot, packageConfig, pubspec); | ||
|
|
||
| File('index.scip').writeAsBytesSync(index.writeToBuffer()); | ||
| print(result['output']); |
There was a problem hiding this comment.
I'm assuming this was left in for debugging purposes, could we remove it?
There was a problem hiding this comment.
Oh, yep! Sorry 😅
|
QA +1
|
|
🚀 @Workiva/release-management-p 🚢 |
|
FYI @isaacharrisholt Thanks again for the contribution! |
3 participants
Closes #168