Skip to content

fix: correct index for limit in book_offers CLI #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bthomee merged 5 commits into from
Nov 20, 2025
Merged

fix: correct index for limit in book_offers CLI #6043

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17e4d38
Fix index for iLimit in RPCCall.cpp
mvadari Nov 17, 2025
e66cfab
fix tests, more cleanup
mvadari Nov 17, 2025
9fb088c
remove debug statements
mvadari Nov 17, 2025
6879fc3
Merge branch 'develop' into mvadari/book-offers-cli-fix
mvadari Nov 18, 2025
532c30e
Merge branch 'develop' into mvadari/book-offers-cli-fix
mvadari Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/xrpld/rpc/detail/RPCCall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ class RPCParser

if (jvParams.size() >= 5)
{
int iLimit = jvParams[5u].asInt();
int iLimit = jvParams[4u].asInt();

if (iLimit > 0)
jvRequest[jss::limit] = iLimit;
Expand Down
Loading