Skip to content

Conversation

@vvysokikh1
Copy link
Collaborator

@vvysokikh1 vvysokikh1 commented Nov 25, 2025

High Level Overview of Change

CI commits:

  1. b550dc0 - (ci: Remove missing commits check #6077) 2025-11-24
  2. adbeb94 - (ci: Only upload artifacts in XRPLF repo owner #6060) 2025-11-20
  3. 3fb6acd - (ci: Fix filtering out of Clang 20+ on ARM #6046) 2025-11-17
  4. 77b7cef - (ci: Use new Debian Trixie images #6034) 2025-11-17
  5. 2237644 - (ci: Trigger clio pipeline on PRs targeting release branches #6080) 2025-11-25
  6. 3330948 - (ci: Update Conan to 2.22.2 #6019) 2025-11-10
  7. 9b53bd9 - (ci: Clean workspace on Windows self-hosted runners #6024) 2025-11-12

Chore commits:

  1. fb74dc2 - (Clean up the comment in NetworkOps_test.cpp #6066) 2025-11-21
  2. ad37461 - (chore: fix some typos in comments #6040) 2025-11-18

Docs commits:

  1. 58e0319 - (Improve VaultWithdraw documentation #6068) 2025-11-21
  2. 5fc07e3 - (chore: fix a large number of spelling issues #6002) 2025-11-12

Fix commits:

  1. 3b810c3 - (fix: JSON parsing of negative STNumber and STAmount #5990) 2025-11-10
  2. 362ecbd - (fix: Apply object reserve for Vault pseudo-account #5954) 2025-11-14

Lending protocol:

  1. 8d1b3b3 - (refactor: Add support for extra transaction signature validation #5851) 2025-10-30

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vvysokikh1 vvysokikh1 requested a review from bthomee November 25, 2025 16:56
@vvysokikh1 vvysokikh1 requested a review from a team as a code owner November 25, 2025 16:56
bthomee and others added 7 commits November 25, 2025 17:29
This change uses the new Debian Trixie CI images added by XRPLF/ci#83.
This change fixes the strategy matrix check to filter out the Clang 20+ on ARM, which still fail due to problems with Boost.
This change prevents uploading too many artifacts in non-public repositories.
This change removes a copyright notice that was accidentally copied over from another file.
This change removes the CI check for missing commits, as well as a stray path to the publish-docs workflow that isn't used in the on-trigger workflow.
@vvysokikh1 vvysokikh1 force-pushed the vvysokikh1/release-3.0-rc2 branch from 140c6df to 7bbd85c Compare November 25, 2025 17:35
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 81.29032% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.7%. Comparing base (e7e4d52) to head (359a57e).

Files with missing lines Patch % Lines
src/xrpld/rpc/detail/TransactionSign.cpp 56.8% 16 Missing ⚠️
src/libxrpl/protocol/STObject.cpp 0.0% 8 Missing ⚠️
src/libxrpl/protocol/STTx.cpp 89.2% 4 Missing ⚠️
src/xrpld/rpc/detail/RPCCall.cpp 91.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-3.0   #6079     +/-   ##
=============================================
- Coverage         78.8%   78.7%   -0.0%     
=============================================
  Files              816     816             
  Lines            68833   68934    +101     
  Branches          8164    8177     +13     
=============================================
+ Hits             54216   54282     +66     
- Misses           14617   14652     +35     
Files with missing lines Coverage Δ
include/xrpl/basics/SlabAllocator.h 93.5% <ø> (ø)
include/xrpl/basics/base_uint.h 97.4% <ø> (ø)
include/xrpl/json/json_value.h 98.5% <ø> (ø)
include/xrpl/protocol/STObject.h 93.1% <ø> (ø)
include/xrpl/protocol/STTx.h 100.0% <100.0%> (ø)
src/libxrpl/basics/BasicConfig.cpp 88.4% <ø> (ø)
src/libxrpl/json/json_value.cpp 99.1% <100.0%> (+0.1%) ⬆️
src/libxrpl/protocol/BuildInfo.cpp 98.1% <ø> (ø)
src/libxrpl/protocol/STAmount.cpp 89.1% <100.0%> (+0.1%) ⬆️
src/libxrpl/protocol/STNumber.cpp 95.4% <100.0%> (ø)
... and 11 more

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Restructures `STTx` signature checking code to be able to handle
  a `sigObject`, which may be the full transaction, or may be an object
  field containing a separate signature. Either way, the `sigObject` can
  be a single- or multi-sign signature.
- This is distinct from 550f90a (#5594), which changed the check in
  Transactor, which validates whether a given account is allowed to sign
  for the given transaction. This cryptographically checks the signature
  validity.
@vvysokikh1 vvysokikh1 force-pushed the vvysokikh1/release-3.0-rc2 branch from 7bbd85c to 2b41496 Compare November 25, 2025 18:31
This change triggers the Clio pipeline on PRs that target any of the `release*` branches (in addition to the `master` branch), as opposed to only the `release` branch.
@vvysokikh1 vvysokikh1 force-pushed the vvysokikh1/release-3.0-rc2 branch from 2b41496 to 7940ea0 Compare November 26, 2025 11:01
Bronek and others added 2 commits November 28, 2025 11:20
This change fixes JSON parsing of negative `int` input in `STNumber` and `STAmount`. The conversion of JSON to `STNumber` or `STAmount` may trigger a condition where we negate smallest possible `int` value, which is undefined behaviour. We use a temporary storage as `int64_t` to avoid this bug. Note that this only affects RPC, because we do not parse JSON in the protocol layer, and hence no amendment is needed.
This updates the CI image hashes after following change: XRPLF/ci#81. And, since we use latest Conan, we can have `conan.lock` with a newline at the end, and we don't need to exclude it from `pre-commit` hooks any longer.
@vvysokikh1 vvysokikh1 force-pushed the vvysokikh1/release-3.0-rc2 branch from 96b9eb5 to d87d7f6 Compare November 28, 2025 11:20
@vvysokikh1 vvysokikh1 force-pushed the vvysokikh1/release-3.0-rc2 branch from d87d7f6 to 359a57e Compare November 28, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants