Skip to content

update ripple-binary-codec to 2.5.1 #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update ripple-binary-codec to 2.5.1 #3126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb795c8
update version
Patel-Raj11 Oct 30, 2025
17ef670
update history
Patel-Raj11 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/xrpl/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Subscribe to [the **xrpl-announce** mailing list](https://groups.google.com/g/xr

### Fixed
* Fix incorrect type checking in `validateVaultCreate` that prevented vault creation with MPT as an asset.
* Update ripple-binary-codec to 2.5.1 to address serialization/deserialization issues in `Issue` serialized type for MPTIssue.

## 4.4.2 (2025-09-25)

Expand Down
2 changes: 1 addition & 1 deletion packages/xrpl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"bignumber.js": "^9.0.0",
"eventemitter3": "^5.0.1",
"ripple-address-codec": "^5.0.0",
"ripple-binary-codec": "^2.5.0",
"ripple-binary-codec": "^2.5.1",
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

LGTM: Patch version bump to ripple-binary-codec is appropriate.

The caret constraint allows for patch and minor updates within the 2.5.x line, which is the correct approach for a non-breaking bug fix. No other dependencies were modified.

Please verify that ripple-binary-codec v2.5.1 is available on npm and has no known security advisories. You can check this with:

🌐 Web query:

ripple-binary-codec 2.5.1 npm security

💡 Result:

Short answer: There are no public security advisories for the ripple-binary-codec package itself — Snyk and npm list no known direct vulnerabilities — but I did not find an npm release tagged 2.5.1 (npm shows 2.5.0). Also note a separate supply‑chain compromise affected the xrpl (xrpl.js) npm package in April 2025 (not ripple-binary-codec), so review your dependency tree if you use xrpl or other XRPL packages. Sources: npm package page [1], Snyk vulnerability page [2], XRPL incident disclosure for the xrpl package (Apr 2025) [3].

Sources:
[1] npm: ripple-binary-codec package page.
[2] Snyk: ripple-binary-codec vulnerability summary.
[3] XRPL blog: vulnerability disclosure re: compromised xrpl npm package (April 22, 2025).

Version 2.5.1 does not exist on npm — revert to ^2.5.0 or verify intended version.

The web search confirms that ripple-binary-codec only has version 2.5.0 available on npm; version 2.5.1 does not exist in the registry. This will cause the package installation to fail or silently fall back. Verify the intended version and update the dependency accordingly. No security advisories exist for ripple-binary-codec itself.

🤖 Prompt for AI Agents 
In packages/xrpl/package.json around line 32, the dependency
"ripple-binary-codec": "^2.5.1" references a non-existent npm version; change
the version to a valid published release (e.g., "^2.5.0") or confirm and set the
intended correct version. Update the package.json dependency entry, run npm
install (or yarn) to verify resolution, and update lockfile if present to
persist the correct version.

Copy link
Collaborator Author

@Patel-Raj11 Patel-Raj11 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.npmjs.com/package/ripple-binary-codec/v/2.5.1

Copy link
Contributor

@coderabbitai coderabbitai bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if ripple-binary-codec version 2.5.1 exists in the npm registry
npm view [email protected] version 2>/dev/null || echo "Version not found"

# Also check all available versions to see the latest
echo "---"
echo "Available versions:"
npm view ripple-binary-codec versions --json 2>/dev/null | jq -r '.[-5:][]' || echo "Could not fetch versions"

# Check publish date if version exists
echo "---"
echo "Version 2.5.1 details:"
npm view [email protected] time version 2>/dev/null || echo "Details not available"

Length of output: 4531

@Patel-Raj11, you're absolutely correct! I apologize for the error in my initial assessment.

Version 2.5.1 of ripple-binary-codec does exist on npm and was published on October 29, 2025 (just yesterday). The web search results I received were outdated or incorrect.

The dependency update from ^2.5.0 to ^2.5.1 is valid and appropriate. Thank you for the correction! ✅

🧠 Learnings used 
Learnt from: shawnxie999
PR: XRPLF/xrpl.js#2661
File: packages/xrpl/test/integration/transactions/mptokenAuthorize.test.ts:29-118
Timestamp: 2024-12-06T19:25:15.376Z
Learning: In the XRPLF/xrpl.js TypeScript client library, when writing tests (e.g., in `packages/xrpl/test/integration/transactions/`), we generally do not need to test rippled server behaviors, because those behaviors are covered by rippled's own integration and unit tests.

"ripple-keypairs": "^2.0.0"
},
"devDependencies": {
Expand Down
Loading