Add deploy_group as a default k8s label
#4123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
EvanKrall
previously approved these changes
Sep 26, 2025
This was initially added just for autoscaling purposes, but it complicates the code a bit to have it only be included for autoscaled instances and it's a somewhat useful label to have for adhoc filtering - so let's do a big bounce to simplify/improve things :)
nemacysts
force-pushed
the
luisp/deploy-group-default
branch
from
0bfab89 to
39cdb22
Compare
jfongatyelp
approved these changes
Oct 17, 2025
jfongatyelp
reviewed
Oct 17, 2025
| # character limit for k8s labels (63 chars) | ||
| labels["paasta.yelp.com/deploy_group"] = self.get_deploy_group() | ||
|
|
||
| # NOTE: these are not mutually exclusive as a service could use multiple autoscaling types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially added just for autoscaling purposes, but it complicates the code a bit to have it only be included for autoscaled instances and it's a somewhat useful label to have for adhoc filtering - so let's do a big bounce to simplify/improve things :)