Allow installation in combination with PHPUnit 4.8.36

To allow for testing on PHP 5.5, PHPUnit 4 is needed.

PHPUnit 4.8.36 is the only version in the 4.x series which contains the forward-compatible layer with the namespaced versions of common PHPUnit classes.

With the additional polyfills which have been put in place, installation of this package on PHP 5.5 in combination with PHPUnit 4.8.36 is now supported.

Includes annotating this change in all the relevant places.
Includes adding a new build to the Travis matrix to also run all tests against PHP 5.5 / PHPUnit 4.8.36.

Author: jrfnl

.travis.yml

@@ -42,6 +42,10 @@ jobs:
         # Check the code style of the code base.
         - composer check-cs
 
+    - stage: test
+      php: 5.5
+      dist: trusty
+
   allow_failures:
     # Allow failures for unstable builds.
     - php: "nightly"

README.md

@@ -24,8 +24,8 @@ Set of polyfills for changed PHPUnit functionality to allow for creating PHPUnit
 Requirements
 -------------------------------------------
 
-* PHP 5.6 or higher.
-* PHPUnit 5.7 - 9.x (automatically required via Composer).
+* PHP 5.5 or higher.
+* PHPUnit 4.8 - 9.x (automatically required via Composer).
 
 
 Installation
@@ -53,7 +53,7 @@ This library is set up to allow for creating PHPUnit cross-version compatible te
 
 This library offers a number of polyfills for functionality which was introduced, split up or renamed in PHPUnit.
 
-### Write your tests for PHPUnit 9.x and run them on PHPUnit 5.7 - 9.x
+### Write your tests for PHPUnit 9.x and run them on PHPUnit 4.8 - 9.x
 
 The polyfills have been setup to allow tests to be _forward_-compatible. What that means is, that your tests can use the assertions supported by the _latest_ PHPUnit version, even when running on older PHPUnit versions.
 

composer.json

@@ -24,7 +24,7 @@
     "prefer-stable": true,
     "require": {
         "php": ">=5.5",
-        "phpunit/phpunit": "^5.7.21 || ^6.0 || ^7.0 || ^8.0 || ^9.0"
+        "phpunit/phpunit": "^4.8.36 || ^5.7.21 || ^6.0 || ^7.0 || ^8.0 || ^9.0"
     },
     "require-dev": {
         "php-parallel-lint/php-parallel-lint": "^1.2.0",

phpunitpolyfills-autoload.php

@@ -241,13 +241,13 @@ public static function loadAssertEqualsSpecializations() {
 		 * if a PHPUnit version is used which already contains this functionality.
 		 *
 		 * Includes aliasing any PHPUnit native classes needed for this functionality
-		 * which aren't available under their namespaced name in PHPUnit 5.x.
+		 * which aren't available under their namespaced name in PHPUnit 4.x/5.x.
 		 *
 		 * @return void
 		 */
 		public static function loadExpectPHPException() {
 			/*
-			 * Alias the PHPUnit 5 Error classes to their PHPUnit >= 6 name.
+			 * Alias the PHPUnit 4/5 Error classes to their PHPUnit >= 6 name.
 			 *
 			 * {@internal The `class_exists` wrappers are needed to play nice with
 			 * PHPUnit bootstrap files of test suites implementing this library
@@ -364,7 +364,7 @@ public static function loadTestCase() {
 		public static function loadTestListenerDefaultImplementation() {
 			if ( \class_exists( PHPUnit_Version::class ) === false ) {
 				/*
-				 * Alias one particular PHPUnit 5 class to its PHPUnit >= 6 name.
+				 * Alias one particular PHPUnit 4/5 class to its PHPUnit >= 6 name.
 				 *
 				 * All other classes needed are part of the forward-compatibility layer.
 				 *

src/Polyfills/AssertIsType.php

@@ -142,7 +142,7 @@ public static function assertIsCallable( $actual, $message = '' ) {
 	 *
 	 * {@internal Support for `iterable` was only added to the `Assert::assertInternalType()` method
 	 * in PHPUnit 7.1.0, so this polyfill can't use that functionality until the minimum supported
-	 * PHPUnit version of this library would be PHPUnit 7.1.0. (Currently 5.7.0).
+	 * PHPUnit version of this library would be PHPUnit 7.1.0.}
 	 *
 	 * @link https://github.com/sebastianbergmann/phpunit/pull/3035 PR which added support for `is_iterable`
 	 *                                                              to `Assert::assertInternalType()`.
@@ -289,7 +289,7 @@ public static function assertIsNotCallable( $actual, $message = '' ) {
 	 *
 	 * {@internal Support for `iterable` was only added to the `Assert::assertNotInternalType()` method
 	 * in PHPUnit 7.1.0, so this polyfill can't use that functionality until the minimum supported
-	 * PHPUnit version of this library would be PHPUnit 7.1.0. (Currently 5.7.0).
+	 * PHPUnit version of this library would be PHPUnit 7.1.0.}
 	 *
 	 * @link https://github.com/sebastianbergmann/phpunit/pull/3035 PR which added support for `is_iterable`
 	 *                                                              to `Assert::assertNotInternalType()`.

src/TestListeners/TestListenerDefaultImplementationPHPUnitLte5.php

@@ -9,7 +9,7 @@
 use PHPUnit_Framework_Warning;
 
 /**
- * Basic TestListener implementation for use with PHPUnit 5.x.
+ * Basic TestListener implementation for use with PHPUnit 4.x and 5.x.
  *
  * This TestListener trait uses renamed (snakecase) methods for all standard methods in
  * a TestListener to get round the method signature changes in various PHPUnit versions.
@@ -20,8 +20,8 @@
  * {@internal While in essence this trait is no different from the PHPUnit 6.x version, this
  * version is necessary as the class/interface name type declarations used in the PHPUnit 6.x
  * file are based on the namespaced names. As both the namespaced names as well as the
- * non-namespaced names exist in PHPUnit 5.7.21+, we cannot create class aliases to get
- * round the signature mismatch and need this trait using the old names instead.}
+ * non-namespaced names exist in PHPUnit 4.8.36+/5.7.21+, we cannot create class aliases to
+ * get round the signature mismatch and need this trait using the old names instead.}
  */
 trait TestListenerDefaultImplementation {