build: run tsc --noEmit on lint (#214)

# Description

`tsup` does not perform strict type checking before the generation of
the `d.ts` files. Adding the `tsc --noEmit` step checks for types
violation.

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Ivan Shymko <[email protected]>

Author: 3 people

package.json

@@ -71,9 +71,8 @@
   "scripts": {
     "clean": "gts clean",
     "build": "tsup",
-    "pretest": "npm run build",
     "test": "mocha \"test/**/*.spec.ts\"",
-    "lint": "npx eslint .",
+    "lint": "tsc --noEmit && npx eslint .",
     "format:readme": "prettier --write ./README.md",
     "lint:fix": "npx eslint . --fix",
     "coverage": "c8 npm run test",

src/samples/agents/movie-agent/index.ts

@@ -254,6 +254,7 @@ const movieAgentCard: AgentCard = {
     url: 'https://example.com/a2a-samples', // Added provider URL
   },
   version: '0.0.2', // Incremented version
+  protocolVersion: '0.3.0',
   capabilities: {
     streaming: true, // The new framework supports streaming
     pushNotifications: false, // Assuming not implemented for this agent yet

test/client/client.spec.ts

@@ -343,7 +343,14 @@ describe('A2AClient Basic Tests', () => {
               streaming: true,
               pushNotifications: true,
             },
-            skills: [],
+            skills: [
+              {
+                id: 'test_agent',
+                name: 'Test Agent',
+                description: 'Simulate the general flow of a streaming agent.',
+                tags: ['test'],
+              },
+            ],
           };
           return createAgentCardResponse(invalidAgentCard);
         }
@@ -419,7 +426,14 @@ describe('A2AClient Basic Tests', () => {
           streaming: true,
           pushNotifications: true,
         },
-        skills: [],
+        skills: [
+          {
+            id: 'test_agent',
+            name: 'Test Agent',
+            description: 'Simulate the general flow of a streaming agent.',
+            tags: ['test'],
+          },
+        ],
       };
       expect(() => new A2AClient(mockAgentCard as any)).to.throw(
         "Provided Agent Card does not contain a valid 'url' for the service endpoint."

test/client/util.ts

@@ -279,7 +279,8 @@ export function createMockFetch(
 
     // Handle API requests
     if (url.includes('/api')) {
-      const authHeader = options?.headers?.['Authorization'] as string;
+      const headers = new Headers(options?.headers);
+      const authHeader = headers.get('Authorization');
 
       // Capture auth headers if requested
       if (captureAuthHeaders) {

test/server/default_request_handler.spec.ts

@@ -29,6 +29,7 @@ import {
   TaskPushNotificationConfig,
   TaskState,
   TaskStatusUpdateEvent,
+  TextPart,
 } from '../../src/index.js';
 import {
   DefaultExecutionEventBusManager,
@@ -44,7 +45,6 @@ import {
 import { MockPushNotificationSender } from './mocks/push_notification_sender.mock.js';
 import { ServerCallContext } from '../../src/server/context.js';
 import { MockTaskStore } from './mocks/task_store.mock.js';
-import { TextPart } from 'genkit/model';
 
 describe('DefaultRequestHandler as A2ARequestHandler', () => {
   let handler: A2ARequestHandler;

test/server/jsonrpc_transport_handler.spec.ts

@@ -4,7 +4,7 @@ import sinon from 'sinon';
 
 import { JsonRpcTransportHandler } from '../../src/server/transports/jsonrpc_transport_handler.js';
 import { A2ARequestHandler } from '../../src/server/request_handler/a2a_request_handler.js';
-import { JSONRPCErrorResponse } from '../../src/index.js';
+import { JSONRPCErrorResponse, JSONRPCRequest } from '../../src/index.js';
 
 describe('JsonRpcTransportHandler', () => {
   let mockRequestHandler: A2ARequestHandler;
@@ -115,7 +115,7 @@ describe('JsonRpcTransportHandler', () => {
     });
 
     it('should handle valid request with null id', async () => {
-      const request = {
+      const request: JSONRPCRequest = {
         jsonrpc: '2.0',
         method: 'message/send',
         id: null,