Skip to content

Conversation

@guglielmo-san
Copy link
Member

@guglielmo-san guglielmo-san commented Nov 12, 2025

Description

The purpose of this PR is implementing the tasks/list api on the server side as for documentation.
New types.ts has been generated to include the parameters for the tasks/list

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #172 🦕

@guglielmo-san
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new tasks/list endpoint. The implementation, however, contains several critical bugs that need to be addressed. These include incorrect filtering logic that fails to apply any filters, a type error in the in-memory store that would cause runtime failures, and a missing return statement in a utility function that breaks timestamp validation. Additionally, there are medium-severity issues related to parameter validation, handling of default values, and code duplication in generated types. I've provided detailed comments and suggestions to fix these issues.

@guglielmo-san
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new tasks/list endpoint, which is a great addition. My review focuses on the implementation details of this new feature. I've found a critical issue where the code would crash due to an undefined variable, as well as several other bugs related to pagination logic, parameter validation, and data handling. These issues could lead to incorrect API behavior, such as wrong total counts, incorrect history slicing, and overly restrictive filtering. I've provided detailed comments and suggestions to address these points.

@guglielmo-san guglielmo-san marked this pull request as ready for review November 12, 2025 17:20
@guglielmo-san guglielmo-san changed the title feat: Implement tasks list refactor: Implement tasks list Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Implement tasks/list api

2 participants