-
Notifications
You must be signed in to change notification settings - Fork 301
Update to specification from b6ef9eec558c877fb69024df090a8bb63c542a1c #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to specification from b6ef9eec558c877fb69024df090a8bb63c542a1c #574
Conversation
Summary of ChangesHello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request brings the A2A specification up to date with the latest changes, impacting the core Protocol Buffer definitions and their generated Python code. The update introduces new functionalities for task management, refines existing data structures, and enhances the API for interacting with agent capabilities and push notifications. These changes aim to improve the robustness, clarity, and extensibility of the A2A protocol. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the generated Python code from version 0.3.0 of the A2A specification. This introduces several breaking changes, such as renaming gRPC methods (e.g., TaskSubscription to SubscribeToTask) and message fields. However, the client and server code that consumes these generated files has not been updated, which will break the build and cause runtime errors. For this PR to be mergeable, it is critical to also include the necessary updates to consumer files like src/a2a/client/transports/grpc.py, src/a2a/server/request_handlers/grpc_handler.py, and their corresponding tests. Additionally, I've noted in my review that some docstrings in the generated a2a_pb2_grpc.py file have become less descriptive, and I recommend restoring the previous level of detail for better maintainability.
| """A2AService defines the operations of the A2A protocol. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated docstring for A2AServiceStub is much less descriptive than the previous version. The old docstring provided valuable context about the design rationale and the resources involved (AgentCard, Message, Task, etc.), which was very helpful for developers trying to understand the service. Consider restoring some of that detail for better maintainability.
| """A2AService defines the operations of the A2A protocol. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """Send a message to the agent. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """SendStreamingMessage is a streaming version of SendMessage. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """Cancel a task. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit: a2aproject/A2A@b6ef9ee