Skip to content

Conversation

@wgd3
Copy link

@wgd3 wgd3 commented Dec 6, 2025

Description

This PR updates the HTTP header name for extension support. It is currently defined as X-A2A-Extensions, however as of this recent commit that has changed:

Changes

The primary change comes from the src/a2a/extensions/common.py file:

HTTP_EXTENSION_HEADER = 'A2A-Extensions'
HTTP_EXTENSION_HEADER_DEPRECATED = 'X-A2A-Extensions'

Minor functional changes were made in the JSON-RPC app:

if not extension_values:
    extension_values = request.headers.getlist(
        HTTP_EXTENSION_HEADER_DEPRECATED
    )

Additional Notes

There is also support for the deprecated X-A2A-Extensions header built-in as part of this PR. I'm happy to remove or enhance this support if necessary.


  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

@wgd3 wgd3 requested a review from a team as a code owner December 6, 2025 17:14
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wgd3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an upstream change in the A2A project by updating the HTTP header used for extension support. The core purpose is to transition to the new 'A2A-Extensions' header while maintaining robust backward compatibility with the previously used 'X-A2A-Extensions' header. This ensures that services can adopt the new standard without immediately breaking existing client integrations, providing a smooth transition path.

Highlights

  • HTTP Header Update: The primary HTTP header for A2A extensions has been updated from 'X-A2A-Extensions' to 'A2A-Extensions' to align with recent changes in the upstream A2A project.
  • Backward Compatibility: Support for the deprecated 'X-A2A-Extensions' header has been explicitly added to ensure backward compatibility for existing clients.
  • Service Integration: Both JSON-RPC and gRPC server request handlers have been updated to prioritize the new header while gracefully falling back to the deprecated header if the new one is not present.
  • Test Updates: Relevant test cases and their docstrings have been updated to reflect the change to the new 'A2A-Extensions' header.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the HTTP header for A2A extensions from X-A2A-Extensions to the standard A2A-Extensions. The implementation thoughtfully includes backward compatibility to support the deprecated header, ensuring a smooth transition. The changes are consistent across the JSON-RPC and gRPC handlers, and the tests have been updated accordingly. I've provided a couple of minor suggestions to improve code conciseness, but overall, this is a solid and well-executed change.

wgd3 and others added 2 commits December 6, 2025 12:24
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant