Skip to content

Conversation

@geojaz
Copy link

@geojaz geojaz commented Aug 4, 2025

When trying to run the demo app as per the instructions: https://github.com/a2aproject/a2a-samples/blob/main/demo/README.md

I get an error something like this:

Traceback (most recent call last):
  File "/Users/eric.hole/dev/geojaz/a2a-samples/demo/ui/main.py", line 28, in <module>
    from service.server.server import ConversationServer
  File "/Users/eric.hole/dev/geojaz/a2a-samples/demo/ui/service/server/server.py", line 27, in <module>
    from .adk_host_manager import ADKHostManager, get_message_id
  File "/Users/eric.hole/dev/geojaz/a2a-samples/demo/ui/service/server/adk_host_manager.py", line 34, in <module>
    from hosts.multiagent.host_agent import HostAgent
  File "/Users/eric.hole/dev/geojaz/a2a-samples/samples/python/hosts/multiagent/host_agent.py", line 28, in <module>
    from .remote_agent_connection import RemoteAgentConnections, TaskUpdateCallback
ImportError: cannot import name 'TaskUpdateCallback' from 'hosts.multiagent.remote_agent_connection' (/Users/eric.hole/dev/geojaz/a2a-samples/samples/python/hosts/multiagent/remote_agent_connection.py)

This fixes things up for me

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @geojaz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed an ImportError that occurred when running the demo application by implementing explicit type definitions for task update callbacks. This change involves importing relevant type-related classes and defining new type aliases to correctly specify the signature of these callback functions, ensuring the application's stability and type correctness.

Highlights

  • New Type Definitions for Task Callbacks: I've introduced new type definitions, 'TaskCallbackArg' and 'TaskUpdateCallback', to accurately describe the expected arguments and return type for functions that handle task updates. This ensures type consistency and helps prevent runtime errors.
  • Dependency Imports: To support the new type definitions, I've added necessary imports for 'Callable' from Python's standard library and 'TaskArtifactUpdateEvent' and 'TaskStatusUpdateEvent' from the 'a2a.client' module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@geojaz geojaz changed the title Add type definitions for task update callbacks fix: Add type definitions for task update callbacks Aug 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an ImportError by adding the necessary type definitions for TaskUpdateCallback. The changes are straightforward and effective. I have one suggestion regarding the new TaskUpdateCallback type to improve clarity and prevent potential misuse, as callbacks are often expected to have no return value, but this one is typed to return a Task.

@holtskinner
Copy link
Member

@pstephengoogle Can you confirm this is WAI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants