Skip to content

Commit c75cd6d

Browse files
oblomov-devoblomov-dev
authored
refactor sample (#213)
1 parent 8d9456b commit c75cd6d

File tree

3 files changed

+42
-91
lines changed

3 files changed

+42
-91
lines changed

‎src/z2ui5_cl_demo_app_000.clas.abap‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,12 +655,20 @@
655655
).
656656

657657
panel->generic_tile(
658-
header = 'Wizard Control'
658+
header = 'Wizard Control I'
659659
press = client->_event( 'z2ui5_cl_demo_app_175' )
660660
mode = 'LineMode'
661661
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
662662
).
663663

664+
panel->generic_tile(
665+
header = 'Wizard Control II'
666+
subheader = 'Next step & SubSequentStep'
667+
press = client->_event( 'z2ui5_cl_demo_app_202' )
668+
mode = 'LineMode'
669+
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
670+
).
671+
664672
panel->generic_tile(
665673
header = 'Cards'
666674
press = client->_event( 'z2ui5_cl_demo_app_181' )
@@ -744,6 +752,14 @@
744752
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
745753
).
746754

755+
panel->generic_tile(
756+
header = 'Nested Views V'
757+
subheader = 'Sub-App'
758+
press = client->_event( 'Z2UI5_CL_DEMO_APP_104' )
759+
mode = 'LineMode'
760+
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
761+
).
762+
747763
panel = page->panel(
748764
expandable = abap_false
749765
expanded = abap_true

‎src/z2ui5_cl_demo_app_104.clas.abap‎

Lines changed: 4 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ CLASS z2ui5_cl_demo_app_104 DEFINITION
99
INTERFACES z2ui5_if_app .
1010

1111
DATA mo_app_sub TYPE REF TO object .
12-
1312
DATA classname TYPE string.
1413

1514
TYPES:
@@ -50,76 +49,43 @@ ENDCLASS.
5049

5150

5251

53-
CLASS Z2UI5_CL_DEMO_APP_104 IMPLEMENTATION.
52+
CLASS z2ui5_cl_demo_app_104 IMPLEMENTATION.
5453

5554

56-
* <SIGNATURE>---------------------------------------------------------------------------------------+
57-
* | Instance Protected Method Z2UI5_CL_DEMO_APP_104->ON_EVENT_SUB
58-
* +-------------------------------------------------------------------------------------------------+
59-
* +--------------------------------------------------------------------------------------</SIGNATURE>
6055
METHOD on_event_sub.
6156

6257
IF mo_app_sub IS BOUND.
6358

6459
ASSIGN mo_app_sub->('MO_VIEW_PARENT') TO FIELD-SYMBOL(<fs>).
65-
6660
<fs> = mo_grid_sub.
67-
68-
CALL METHOD mo_app_sub->('Z2UI5_IF_APP~MAIN') EXPORTING client = client .
61+
CALL METHOD mo_app_sub->('Z2UI5_IF_APP~MAIN') EXPORTING client = client.
6962

7063
ENDIF.
7164
ENDMETHOD.
7265

7366

74-
* <SIGNATURE>---------------------------------------------------------------------------------------+
75-
* | Instance Protected Method Z2UI5_CL_DEMO_APP_104->ON_INIT_SUB
76-
* +-------------------------------------------------------------------------------------------------+
77-
* +--------------------------------------------------------------------------------------</SIGNATURE>
7867
METHOD on_init_sub.
7968

8069
classname = to_upper( classname ).
8170
CREATE OBJECT mo_app_sub TYPE (classname).
8271

8372
ASSIGN mo_app_sub->('MO_VIEW_PARENT') TO FIELD-SYMBOL(<fs>).
84-
8573
<fs> = mo_grid_sub.
86-
87-
CALL METHOD mo_app_sub->('Z2UI5_IF_APP~MAIN') EXPORTING client = client .
74+
CALL METHOD mo_app_sub->('Z2UI5_IF_APP~MAIN') EXPORTING client = client.
8875

8976
ENDMETHOD.
9077

9178

92-
* <SIGNATURE>---------------------------------------------------------------------------------------+
93-
* | Instance Protected Method Z2UI5_CL_DEMO_APP_104->VIEW_DISPLAY_DETAIL
94-
* +-------------------------------------------------------------------------------------------------+
95-
* +--------------------------------------------------------------------------------------</SIGNATURE>
9679
METHOD view_display_detail.
9780

9881
lo_view_nested = z2ui5_cl_xml_view=>factory( ).
99-
10082
DATA(page) = lo_view_nested->page( title = `Nested View` ).
101-
10283
mo_grid_sub = page->grid( 'L12 M12 S12'
10384
)->content( 'layout' ).
10485

105-
* )->ui_row_action_item( type = `Navigation` "icon = `sap-icon://navigation-right-arrow`
106-
* press = client->_event( val = 'ROW_NAVIGATE' t_arg = VALUE #( ( `${TITLE}` ) ) )
107-
* ).
108-
109-
* client->nest_view_display(
110-
* val = lo_view_nested->stringify( )
111-
* id = `test`
112-
* method_insert = 'addMidColumnPage'
113-
* method_destroy = 'removeAllMidColumnPages'
114-
* ).
115-
11686
ENDMETHOD.
11787

11888

119-
* <SIGNATURE>---------------------------------------------------------------------------------------+
120-
* | Instance Protected Method Z2UI5_CL_DEMO_APP_104->VIEW_DISPLAY_MASTER
121-
* +-------------------------------------------------------------------------------------------------+
122-
* +--------------------------------------------------------------------------------------</SIGNATURE>
12389
METHOD view_display_master.
12490

12591
DATA(page) = z2ui5_cl_xml_view=>factory(
@@ -156,11 +122,6 @@ CLASS Z2UI5_CL_DEMO_APP_104 IMPLEMENTATION.
156122
ENDMETHOD.
157123

158124

159-
* <SIGNATURE>---------------------------------------------------------------------------------------+
160-
* | Instance Public Method Z2UI5_CL_DEMO_APP_104->Z2UI5_IF_APP~MAIN
161-
* +-------------------------------------------------------------------------------------------------+
162-
* | [--->] CLIENT TYPE REF TO Z2UI5_IF_CLIENT
163-
* +--------------------------------------------------------------------------------------</SIGNATURE>
164125
METHOD z2ui5_if_app~main.
165126

166127
me->client = client.
@@ -174,7 +135,6 @@ CLASS Z2UI5_CL_DEMO_APP_104 IMPLEMENTATION.
174135
).
175136

176137
mv_layout = `OneColumn`.
177-
178138
view_display_master( ).
179139
view_display_detail( ).
180140

@@ -191,26 +151,20 @@ CLASS Z2UI5_CL_DEMO_APP_104 IMPLEMENTATION.
191151
APPEND ls_sel TO t_tab2.
192152

193153
IF classname IS NOT INITIAL.
194-
CALL METHOD mo_app_sub->('BIND_CLEAR') EXPORTING client = client.
195154
view_display_master( ).
196155
ENDIF.
197156
classname = ls_sel-info.
198157

199158
mv_layout = `TwoColumnsMidExpanded`.
200-
201-
* client->nest_view_model_update( ).
202159
client->view_model_update( ).
203-
204160
view_display_detail( ).
205-
206161
on_init_sub( ).
207162

208163
client->nest_view_display(
209164
val = lo_view_nested->stringify( )
210165
id = `test`
211166
method_insert = 'addMidColumnPage'
212-
method_destroy = 'removeAllMidColumnPages'
213-
).
167+
method_destroy = 'removeAllMidColumnPages' ).
214168

215169
WHEN 'BACK'.
216170
client->nav_app_leave( client->get_app( client->get( )-s_draft-id_prev_app_stack ) ).

‎src/z2ui5_cl_demo_app_112.clas.abap‎

Lines changed: 21 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,41 @@
1-
class z2ui5_cl_demo_app_112 definition
2-
public
3-
create public .
1+
CLASS z2ui5_cl_demo_app_112 DEFINITION
2+
PUBLIC
3+
CREATE PUBLIC .
44

5-
public section.
5+
PUBLIC SECTION.
66

77

8-
interfaces Z2UI5_IF_APP .
8+
INTERFACES z2ui5_if_app .
99

10-
data CLIENT type ref to Z2UI5_IF_CLIENT .
11-
data MO_VIEW_PARENT type ref to Z2UI5_CL_XML_VIEW .
12-
data MV_CLASS_2 type STRING .
13-
data MV_INIT type ABAP_BOOL .
14-
data MR_DATA type ref to DATA .
10+
DATA client TYPE REF TO z2ui5_if_client .
11+
DATA mo_view_parent TYPE REF TO z2ui5_cl_xml_view .
12+
DATA mv_class_2 TYPE string .
13+
DATA mv_init TYPE abap_bool .
14+
DATA mr_data TYPE REF TO data .
1515

16-
methods ON_INIT .
17-
methods ON_EVENT .
18-
methods DISPLAY_VIEW
19-
changing
20-
!XML type ref to Z2UI5_CL_XML_VIEW optional .
16+
METHODS on_init .
17+
METHODS on_event .
18+
METHODS display_view
19+
CHANGING
20+
!xml TYPE REF TO z2ui5_cl_xml_view OPTIONAL .
2121
PROTECTED SECTION.
2222
PRIVATE SECTION.
2323

2424
ENDCLASS.
2525

2626

2727

28-
CLASS Z2UI5_CL_DEMO_APP_112 IMPLEMENTATION.
28+
CLASS z2ui5_cl_demo_app_112 IMPLEMENTATION.
2929

3030

31-
* <SIGNATURE>---------------------------------------------------------------------------------------+
32-
* | Instance Public Method Z2UI5_CL_DEMO_APP_A_B_C->DISPLAY_VIEW
33-
* +-------------------------------------------------------------------------------------------------+
34-
* | [<-->] XML TYPE REF TO Z2UI5_CL_XML_VIEW(optional)
35-
* +--------------------------------------------------------------------------------------</SIGNATURE>
36-
METHOD DISPLAY_VIEW.
31+
METHOD display_view.
3732

38-
mo_view_parent->input( value = client->_bind_edit( MV_CLASS_2 ) placeholder = `Input From Class 2` ).
33+
mo_view_parent->input( value = client->_bind_edit( mv_class_2 ) placeholder = `Input From Class 2` ).
3934

4035
ENDMETHOD.
4136

4237

43-
* <SIGNATURE>---------------------------------------------------------------------------------------+
44-
* | Instance Public Method Z2UI5_CL_DEMO_APP_A_B_C->ON_EVENT
45-
* +-------------------------------------------------------------------------------------------------+
46-
* +--------------------------------------------------------------------------------------</SIGNATURE>
47-
METHOD ON_EVENT.
38+
METHOD on_event.
4839

4940
CASE client->get( )-event.
5041

@@ -56,24 +47,14 @@ CLASS Z2UI5_CL_DEMO_APP_112 IMPLEMENTATION.
5647
ENDMETHOD.
5748

5849

59-
* <SIGNATURE>---------------------------------------------------------------------------------------+
60-
* | Instance Public Method Z2UI5_CL_DEMO_APP_A_B_C->ON_INIT
61-
* +-------------------------------------------------------------------------------------------------+
62-
* +--------------------------------------------------------------------------------------</SIGNATURE>
63-
METHOD ON_INIT.
50+
METHOD on_init.
6451

6552
* mv_descr = `data sub app`.
6653
display_view( ).
6754

6855
ENDMETHOD.
6956

70-
71-
* <SIGNATURE>---------------------------------------------------------------------------------------+
72-
* | Instance Public Method Z2UI5_CL_DEMO_APP_A_B_C->Z2UI5_IF_APP~MAIN
73-
* +-------------------------------------------------------------------------------------------------+
74-
* | [--->] CLIENT TYPE REF TO Z2UI5_IF_CLIENT
75-
* +--------------------------------------------------------------------------------------</SIGNATURE>
76-
METHOD Z2UI5_IF_APP~MAIN.
57+
METHOD z2ui5_if_app~main.
7758

7859
me->client = client.
7960

0 commit comments

Comments
 (0)