Add tests

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

src/fetchcode/cpan.py

@@ -14,6 +14,8 @@
 # CONDITIONS OF ANY KIND, either express or implied. See the License for the
 # specific language governing permissions and limitations under the License.
 
+import urllib.parse
+
 from packageurl import PackageURL
 
 from fetchcode import fetch_json_response
@@ -34,8 +36,10 @@ def get_download_url(purl: str):
             return None
 
         try:
-            api = f"https://fastapi.metacpan.org/v1/release/{urllib.parse.quote(p.name)}/{urllib.parse.quote(p.version)}"
-            data = fetch_json_response(api, stream=False, timeout=20)
+            parsed_name = urllib.parse.quote(p.name)
+            parsed_version = urllib.parse.quote(p.version)
+            api = f"https://fastapi.metacpan.org/v1/release/{parsed_name}/{parsed_version}"
+            data = fetch_json_response(url=api)
             url = data.get("download_url") or data.get("archive")
             if url and _http_exists(url):
                 return url

tests/test_composer.py

@@ -0,0 +1,81 @@
+# fetchcode is a free software tool from nexB Inc. and others.
+# Visit https://github.com/aboutcode-org/fetchcode for support and download.
+#
+# Copyright (c) nexB Inc. and others. All rights reserved.
+# http://nexb.com and http://aboutcode.org
+#
+# This software is licensed under the Apache License version 2.0.
+#
+# You may not use this software except in compliance with the License.
+# You may obtain a copy of the License at:
+# http://apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+
+from unittest.mock import patch
+
+import pytest
+
+from fetchcode.composer import Composer
+
+
+def test_valid_composer_package_with_namespace():
+    purl = "pkg:composer/laravel/[email protected]"
+    name = "laravel/framework"
+    expected_url = f"https://repo.packagist.org/p2/{name}.json "
+    download_url = "https://github.com/laravel/framework/archive/refs/tags/v10.0.0.zip"
+
+    mock_data = {"packages": {name: [{"version": "10.0.0", "dist": {"url": download_url}}]}}
+
+    with patch("fetchcode.composer.fetch_json_response", return_value=mock_data) as mock_fetch:
+        result = Composer.get_download_url(purl)
+        assert result == download_url
+        mock_fetch.assert_called_once_with(expected_url)
+
+
+def test_valid_composer_package_without_namespace():
+    purl = "pkg:composer/[email protected]"
+    name = "some-package"
+    expected_url = f"https://repo.packagist.org/p2/{name}.json "
+    download_url = "https://example.org/some-package-1.0.0.zip"
+
+    mock_data = {"packages": {name: [{"version": "1.0.0", "dist": {"url": download_url}}]}}
+
+    with patch("fetchcode.composer.fetch_json_response", return_value=mock_data) as mock_fetch:
+        result = Composer.get_download_url(purl)
+        assert result == download_url
+        mock_fetch.assert_called_once_with(expected_url)
+
+
+def test_version_not_found_returns_none():
+    purl = "pkg:composer/laravel/[email protected]"
+    name = "laravel/framework"
+    mock_data = {"packages": {name: [{"version": "9.0.0", "dist": {"url": "https://old.zip"}}]}}
+
+    with patch("fetchcode.composer.fetch_json_response", return_value=mock_data):
+        result = Composer.get_download_url(purl)
+        assert result is None
+
+
+def test_missing_packages_key_returns_none():
+    purl = "pkg:composer/laravel/[email protected]"
+    with patch("fetchcode.composer.fetch_json_response", return_value={}):
+        result = Composer.get_download_url(purl)
+        assert result is None
+
+
+def test_missing_package_name_in_data_returns_none():
+    purl = "pkg:composer/laravel/[email protected]"
+    mock_data = {"packages": {"some/other": []}}
+
+    with patch("fetchcode.composer.fetch_json_response", return_value=mock_data):
+        result = Composer.get_download_url(purl)
+        assert result is None
+
+
+def test_missing_version_raises():
+    purl = "pkg:composer/laravel/framework"
+    with pytest.raises(ValueError, match="Composer PURL must specify a name and version"):
+        Composer.get_download_url(purl)

tests/test_cpan.py

@@ -0,0 +1,86 @@
+# fetchcode is a free software tool from nexB Inc. and others.
+# Visit https://github.com/aboutcode-org/fetchcode for support and download.
+#
+# Copyright (c) nexB Inc. and others. All rights reserved.
+# http://nexb.com and http://aboutcode.org
+#
+# This software is licensed under the Apache License version 2.0.
+#
+# You may not use this software except in compliance with the License.
+# You may obtain a copy of the License at:
+# http://apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+
+from unittest.mock import patch
+
+import pytest
+
+from fetchcode.cpan import CPAN
+
+get_download_url = CPAN.get_download_url
+
+
+@pytest.fixture
+def valid_purl():
+    return "pkg:cpan/EXAMPLE/[email protected]"
+
+
+def test_success_from_metacpan_api(valid_purl):
+    expected_url = "https://cpan.metacpan.org/authors/id/E/EX/EXAMPLE/Some-Module-1.2.3.tar.gz"
+
+    with patch("fetchcode.cpan.fetch_json_response") as mock_fetch, patch(
+        "fetchcode.cpan._http_exists"
+    ) as mock_exists:
+        mock_fetch.return_value = {"download_url": expected_url}
+        mock_exists.return_value = True
+        result = get_download_url(valid_purl)
+        assert result == expected_url
+        mock_fetch.assert_called_once()
+        mock_exists.assert_called_once_with(expected_url)
+
+
+def test_fallback_to_author_path(valid_purl):
+    expected_url = "https://cpan.metacpan.org/authors/id/E/EX/EXAMPLE/Some-Module-1.2.3.tar.gz"
+
+    with patch("fetchcode.cpan.fetch_json_response", side_effect=Exception("API error")), patch(
+        "fetchcode.cpan._http_exists"
+    ) as mock_exists:
+
+        mock_exists.side_effect = lambda url: url.endswith(".tar.gz")
+
+        result = get_download_url(valid_purl)
+        assert result == expected_url
+        assert mock_exists.call_count >= 1
+
+
+def test_author_zip_fallback(valid_purl):
+    tar_url = "https://cpan.metacpan.org/authors/id/E/EX/EXAMPLE/Some-Module-1.2.3.tar.gz"
+    zip_url = "https://cpan.metacpan.org/authors/id/E/EX/EXAMPLE/Some-Module-1.2.3.zip"
+
+    with patch("fetchcode.cpan.fetch_json_response", return_value={}), patch(
+        "fetchcode.cpan._http_exists"
+    ) as mock_exists:
+
+        mock_exists.side_effect = lambda url: url == zip_url
+
+        result = get_download_url(valid_purl)
+        assert result == zip_url
+        assert mock_exists.call_count == 2
+        assert tar_url in [call[0][0] for call in mock_exists.call_args_list]
+
+
+def test_neither_api_nor_fallback_works(valid_purl):
+    with patch("fetchcode.cpan.fetch_json_response", return_value={}), patch(
+        "fetchcode.cpan._http_exists", return_value=False
+    ) as mock_exists:
+
+        result = get_download_url(valid_purl)
+        assert result is None
+        assert mock_exists.call_count == 2
+
+
+def test_missing_name_or_version():
+    assert get_download_url("pkg:cpan/EXAMPLE/Some-Module") is None