Fix rails 7.2 loading (#1534)

* Wrap Polyamorous module in on_load(:active_record)

* Remove defined? ActiveRecord check from form builder

* Require ActiveSupport.on_load explicitly

* Load ransack first in specs to expose load order issues

* Requiring more pieces of ActiveSupport

I am not sure whether going down this path is the best approach. I feel
that perhaps ActiveSupport could require everything within
active_support/core_ext to ensure that active_support/core_ext can load
itself. Still, there's no changing old versions of Rails, so I suppose
this solution works? I am also not sure what the Rails team would
recommend when it comes to requiring specific pieces of ActiveSupport
(to leverage things like mattr_accessor).

In any case, I was able to reproduce the CI failures locally and these
changes make everything pass for me locally.

---------

Co-authored-by: Sean <[email protected]>
Co-authored-by: Greg Molnar <[email protected]>

Author: 3 people

lib/polyamorous/polyamorous.rb

@@ -1,4 +1,4 @@
-if defined?(::ActiveRecord)
+ActiveSupport.on_load(:active_record) do
   module Polyamorous
     InnerJoin = Arel::Nodes::InnerJoin
     OuterJoin = Arel::Nodes::OuterJoin

lib/ransack.rb

@@ -1,3 +1,11 @@
+require 'active_support/dependencies/autoload'
+require 'active_support/deprecation'
+require 'active_support/version'
+
+if ::ActiveSupport.version >= ::Gem::Version.new("7.1")
+  require 'active_support/deprecator'
+end
+
 require 'active_support/core_ext'
 require 'ransack/configuration'
 require 'polyamorous/polyamorous'

lib/ransack/helpers/form_builder.rb

@@ -6,13 +6,12 @@ module ActionView::Helpers::Tags
   # https://github.com/rails/rails/commit/c1a118a
   class Base
     private
-    if defined? ::ActiveRecord
-      def value
-        if @allow_method_names_outside_object
-          object.send @method_name if object && object.respond_to?(@method_name, true)
-        else
-          object.send @method_name if object
-        end
+
+    def value
+      if @allow_method_names_outside_object
+        object.send @method_name if object && object.respond_to?(@method_name, true)
+      else
+        object.send @method_name if object
       end
     end
   end

spec/spec_helper.rb

@@ -1,13 +1,12 @@
-require 'machinist/active_record'
-require 'polyamorous/polyamorous'
+require 'ransack'
 require 'sham'
 require 'faker'
-require 'ransack'
 require 'action_controller'
 require 'ransack/helpers'
 require 'pry'
 require 'simplecov'
 require 'byebug'
+require 'machinist/active_record'
 
 SimpleCov.start
 I18n.enforce_available_locales = false