implement getters

Author: anonrig

include/ada/url_pattern-inl.h

@@ -26,33 +26,37 @@ inline const std::vector<std::string>& URLPattern::Component::get_names()
   return names;
 }
 
-inline const URLPattern::Component& URLPattern::get_protocol() const
-    ada_lifetime_bound {
-  return protocol;
+inline std::string_view URLPattern::get_protocol() const ada_lifetime_bound {
+  // Return this's associated URL pattern's protocol component's pattern string.
+  return protocol.get_pattern();
 }
-inline const URLPattern::Component& URLPattern::get_username() const
-    ada_lifetime_bound {
-  return username;
+inline std::string_view URLPattern::get_username() const ada_lifetime_bound {
+  // Return this's associated URL pattern's username component's pattern string.
+  return username.get_pattern();
 }
-inline const URLPattern::Component& URLPattern::get_password() const
-    ada_lifetime_bound {
-  return password;
+inline std::string_view URLPattern::get_password() const ada_lifetime_bound {
+  // Return this's associated URL pattern's password component's pattern string.
+  return password.get_pattern();
 }
-inline const URLPattern::Component& URLPattern::get_port() const
-    ada_lifetime_bound {
-  return port;
+inline std::string_view URLPattern::get_hostname() const ada_lifetime_bound {
+  // Return this's associated URL pattern's hostname component's pattern string.
+  return hostname.get_pattern();
 }
-inline const URLPattern::Component& URLPattern::get_pathname() const
-    ada_lifetime_bound {
-  return pathname;
+inline std::string_view URLPattern::get_port() const ada_lifetime_bound {
+  // Return this's associated URL pattern's port component's pattern string.
+  return port.get_pattern();
 }
-inline const URLPattern::Component& URLPattern::get_search() const
-    ada_lifetime_bound {
-  return search;
+inline std::string_view URLPattern::get_pathname() const ada_lifetime_bound {
+  // Return this's associated URL pattern's pathname component's pattern string.
+  return pathname.get_pattern();
 }
-inline const URLPattern::Component& URLPattern::get_hash() const
-    ada_lifetime_bound {
-  return hash;
+inline std::string_view URLPattern::get_search() const ada_lifetime_bound {
+  // Return this's associated URL pattern's search component's pattern string.
+  return search.get_pattern();
+}
+inline std::string_view URLPattern::get_hash() const ada_lifetime_bound {
+  // Return this's associated URL pattern's hash component's pattern string.
+  return hash.get_pattern();
 }
 
 inline bool URLPattern::case_ignored() const ada_lifetime_bound {
@@ -61,4 +65,4 @@ inline bool URLPattern::case_ignored() const ada_lifetime_bound {
 
 }  // namespace ada
 
-#endif
+#endif

include/ada/url_pattern.h

@@ -136,13 +136,22 @@ class URLPattern {
   bool test(std::optional<Input> input,
             std::optional<std::string_view> base_url);
 
-  const Component& get_protocol() const ada_lifetime_bound;
-  const Component& get_username() const ada_lifetime_bound;
-  const Component& get_password() const ada_lifetime_bound;
-  const Component& get_port() const ada_lifetime_bound;
-  const Component& get_pathname() const ada_lifetime_bound;
-  const Component& get_search() const ada_lifetime_bound;
-  const Component& get_hash() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-protocol
+  std::string_view get_protocol() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-username
+  std::string_view get_username() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-password
+  std::string_view get_password() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-hostname
+  std::string_view get_hostname() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-port
+  std::string_view get_port() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-pathname
+  std::string_view get_pathname() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-search
+  std::string_view get_search() const ada_lifetime_bound;
+  // @see https://urlpattern.spec.whatwg.org/#dom-urlpattern-hash
+  std::string_view get_hash() const ada_lifetime_bound;
 
   // If ignoreCase is true, the JavaScript regular expression created for each
   // pattern must use the `vi` flag. Otherwise, they must use the `v` flag.
@@ -152,6 +161,7 @@ class URLPattern {
   Component protocol;
   Component username;
   Component password;
+  Component hostname;
   Component port;
   Component pathname;
   Component search;