Skip to content

Conversation

@clayreimann
Copy link

@clayreimann clayreimann commented Sep 4, 2025

Brief summary

  • enable logs page on iOS
  • wrap long identifiers in logs UI
  • persist logs in Realm
  • update editorconfig, podfile, and readme

Which issue is fixed?

Pull Request Type

iOS only

In-depth Description

Adding the logs to the iOS build to help with tracking down player sync issues.

How have you tested this?

Running on my device

Screenshots

image

@Vito0912
Copy link
Contributor

Vito0912 commented Sep 4, 2025

Wouldn't it make more sense to replace the current logger or connect to it (if possible) like it was done with Android?

@clayreimann
Copy link
Author

clayreimann commented Sep 4, 2025

Wouldn't it make more sense to replace the current logger or connect to it (if possible) like it was done with Android?

Not sure what you mean. Like replace the let logger: AppLogger instances in each class and just funnel all logs through this the AbsLogger? I've started doing that, but funneling everything to a single AppLogger loses some of the granularity in filtering since it's all coming from the same place. Like not creating a new SLF4J logger per class (which is customary on all the java/scala codebases I've worked on).

It might be a good idea to have an option to suppress the console logging for other native code calling the logger though, to prevent double log lines.

Edit: though of a way to both replace the current logging with the plugin and maintain specificity. Will update PR.

- enable logs page on iOS
- centralize all logging
- wrap long identifiers in logs UI
- update editorconfig for swift files
- update podfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants