Merge pull request #5131 from ag-grid/AG-15866/fix_label_itemStyler_highlight

AG-15866 Fix `label.itemStyler` highlight updates

Author: alantreadway

packages/ag-charts-community/src/chart/series/polar/donutSeries.ts

@@ -1862,7 +1862,11 @@ export class DonutSeries extends PolarSeries<PieDonutNodeDatum, AgDonutSeriesOpt
     }
 
     protected override hasItemStylers(): boolean {
-        const { itemStyler, calloutLabel, sectorLabel } = this.properties;
-        return (itemStyler ?? calloutLabel.itemStyler ?? sectorLabel.itemStyler) != null;
+        return !(
+            this.properties.itemStyler == null &&
+            this.properties.calloutLabel.itemStyler == null &&
+            this.properties.sectorLabel.itemStyler == null &&
+            this.properties.innerLabels.every((innerLabel) => innerLabel.itemStyler == null)
+        );
     }
 }

packages/ag-charts-community/src/chart/series/series.ts

@@ -656,16 +656,16 @@ export abstract class Series<
         // Force re-check of layer z-index
         this.setSeriesIndex(this.declarationOrder);
 
-        if (currentHighlightState === previousHighlightState) {
+        // Check if there are any itemStylers that might need to react to highlight changes
+        const hasItemStylers = this.hasItemStylers();
+
+        if (!hasItemStylers && currentHighlightState === previousHighlightState) {
             this.hasChangesOnHighlight = false;
             return;
         }
 
         const { highlightedSeries, unhighlightedItem, unhighlightedSeries } = this.properties.highlight;
 
-        // Check if there are any itemStylers that might need to react to highlight changes
-        const hasItemStylers = this.hasItemStylers();
-
         this.hasChangesOnHighlight =
             hasItemStylers ||
             !isEmptyObject(highlightedSeries) ||

packages/ag-charts-enterprise/src/series/chord/chordSeries.ts

@@ -628,6 +628,10 @@ export class ChordSeries extends FlowProportionSeries<
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.node.itemStyler != null || this.properties.link.itemStyler != null;
+        return (
+            this.properties.node.itemStyler != null ||
+            this.properties.link.itemStyler != null ||
+            this.properties.label.itemStyler != null
+        );
     }
 }

packages/ag-charts-enterprise/src/series/funnel/baseFunnelSeries.ts

@@ -642,6 +642,6 @@ export abstract class BaseFunnelSeries<
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.itemStyler != null;
+        return this.properties.itemStyler != null || this.properties.label.itemStyler != null;
     }
 }

packages/ag-charts-enterprise/src/series/heatmap/heatmapSeries.ts

@@ -605,6 +605,6 @@ export class HeatmapSeries extends _ModuleSupport.CartesianSeries<
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.itemStyler != null;
+        return this.properties.itemStyler != null || this.properties.label.itemStyler != null;
     }
 }

packages/ag-charts-enterprise/src/series/linear-gauge/linearGaugeSeries.ts

@@ -1265,6 +1265,6 @@ export class LinearGaugeSeries extends _ModuleSupport.Series<
     }
 
     protected override hasItemStylers(): boolean {
-        return false;
+        return this.properties.label.itemStyler != null;
     }
 }

packages/ag-charts-enterprise/src/series/map-line/mapLineSeries.ts

@@ -730,6 +730,6 @@ export class MapLineSeries extends TopologySeries<
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.itemStyler != null;
+        return this.properties.itemStyler != null || this.properties.label.itemStyler != null;
     }
 }

packages/ag-charts-enterprise/src/series/map-marker/mapMarkerSeries.ts

@@ -922,6 +922,6 @@ export class MapMarkerSeries
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.itemStyler != null;
+        return this.properties.itemStyler != null || this.properties.label.itemStyler != null;
     }
 }

packages/ag-charts-enterprise/src/series/map-shape/mapShapeSeries.ts

@@ -755,6 +755,6 @@ export class MapShapeSeries
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.itemStyler != null;
+        return this.properties.itemStyler != null || this.properties.label.itemStyler != null;
     }
 }

packages/ag-charts-enterprise/src/series/nightingale/nightingaleSeries.ts

@@ -66,6 +66,6 @@ export class NightingaleSeries extends RadialColumnSeriesBase<_ModuleSupport.Sec
     }
 
     protected override hasItemStylers(): boolean {
-        return this.properties.itemStyler != null;
+        return this.properties.itemStyler != null || this.properties.label.itemStyler != null;
     }
 }