Skip to content

Commit 9bf20c8

Browse files
committed
Markers map is final and initialized inline.
1 parent d2d6ba8 commit 9bf20c8

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

library/src/main/java/com/airbnb/android/airmapview/NativeGoogleMapFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,14 @@
2929
import com.google.android.gms.maps.model.Polygon;
3030

3131
import java.util.HashMap;
32+
import java.util.Map;
3233

3334
public class NativeGoogleMapFragment extends SupportMapFragment implements AirMapInterface {
3435

3536
private GoogleMap googleMap;
3637
private OnMapLoadedListener onMapLoadedListener;
3738
private boolean myLocationEnabled;
38-
private HashMap<Marker, AirMapMarker> markers;
39+
private final Map<Marker, AirMapMarker<?>> markers = new HashMap<>();
3940

4041
public static NativeGoogleMapFragment newInstance(AirGoogleMapOptions options) {
4142
return new NativeGoogleMapFragment().setArguments(options);
@@ -61,7 +62,6 @@ public void init() {
6162
public void onMapReady(GoogleMap googleMap) {
6263
if (googleMap != null && getActivity() != null) {
6364
NativeGoogleMapFragment.this.googleMap = googleMap;
64-
NativeGoogleMapFragment.this.markers = new HashMap<>();
6565
UiSettings settings = NativeGoogleMapFragment.this.googleMap.getUiSettings();
6666
settings.setZoomControlsEnabled(false);
6767
settings.setMyLocationButtonEnabled(false);

library/src/main/java/com/airbnb/android/airmapview/WebViewMapFragment.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@
3535

3636
import java.util.HashMap;
3737
import java.util.Locale;
38+
import java.util.Map;
3839

3940
public abstract class WebViewMapFragment extends Fragment implements AirMapInterface {
4041

4142
private static final String TAG = WebViewMapFragment.class.getSimpleName();
4243

4344
protected WebView webView;
4445
private ViewGroup mLayout;
45-
private HashMap<Long, AirMapMarker> markers;
4646
private OnMapClickListener onMapClickListener;
4747
private OnCameraChangeListener onCameraChangeListener;
4848
private OnMapLoadedListener onMapLoadedListener;
@@ -56,6 +56,7 @@ public abstract class WebViewMapFragment extends Fragment implements AirMapInter
5656
private boolean loaded;
5757
private boolean ignoreNextMapMove;
5858
private View infoWindowView;
59+
private final Map<Long, AirMapMarker<?>> markers = new HashMap<>();
5960

6061
private boolean trackUserLocation = false;
6162

@@ -81,8 +82,6 @@ public class GeoWebChromeClient extends WebChromeClient {
8182
webView = (WebView) view.findViewById(R.id.webview);
8283
mLayout = (ViewGroup) view;
8384

84-
markers = new HashMap<>();
85-
8685
WebSettings webViewSettings = webView.getSettings();
8786
webViewSettings.setSupportZoom(true);
8887
webViewSettings.setBuiltInZoomControls(false);

0 commit comments

Comments
 (0)