eslint v9 changes

Author: Bilal-S

package.json

@@ -10,12 +10,12 @@
     "lint": "markdownlint --config linters/.markdownlint.json README.md */README.md",
     "pretest": "npm run --silent lint",
     "test": "npm run --silent test:config && npm run --silent test:config:base",
-    "test:config": "cd packages/eslint-config-airbnb; npm test",
-    "test:config:base": "cd packages/eslint-config-airbnb-base; npm test",
+    "test:config": "cd packages/eslint-config-airbnb && npm test",
+    "test:config:base": "cd packages/eslint-config-airbnb-base && npm test",
     "pretravis": "npm run --silent lint",
     "travis": "npm run --silent travis:config && npm run --silent travis:config:base",
-    "travis:config": "cd packages/eslint-config-airbnb; npm run travis",
-    "travis:config:base": "cd packages/eslint-config-airbnb-base; npm run travis"
+    "travis:config": "cd packages/eslint-config-airbnb && npm run travis",
+    "travis:config:base": "cd packages/eslint-config-airbnb-base && npm run travis"
   },
   "repository": {
     "type": "git",

packages/eslint-config-airbnb-base/.eslintrc

@@ -0,0 +1,14 @@
+const globals = require('globals');
+const airbnbBase = require('./index');
+
+module.exports = [
+  {
+    ...airbnbBase,
+    languageOptions: {
+      ...airbnbBase.languageOptions,
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+];

packages/eslint-config-airbnb-base/eslint.config.js

@@ -1,17 +1,33 @@
+const stylisticJs = require('@stylistic/eslint-plugin-js');
+const importPlugin = require('eslint-plugin-import');
+const bestPractices = require('./rules/best-practices');
+const errors = require('./rules/errors');
+const node = require('./rules/node');
+const style = require('./rules/style');
+const variables = require('./rules/variables');
+const es6 = require('./rules/es6');
+const imports = require('./rules/imports');
+const strict = require('./rules/strict');
+
 module.exports = {
-  extends: [
-    './rules/best-practices',
-    './rules/errors',
-    './rules/node',
-    './rules/style',
-    './rules/variables',
-    './rules/es6',
-    './rules/imports',
-    './rules/strict',
-  ].map(require.resolve),
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: 'module',
+  plugins: {
+    '@stylistic/js': stylisticJs,
+    import: importPlugin,
+  },
+  languageOptions: {
+    parserOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'module',
+    },
+  },
+  rules: {
+    ...bestPractices.rules,
+    ...errors.rules,
+    ...node.rules,
+    ...style.rules,
+    ...variables.rules,
+    ...es6.rules,
+    ...imports.rules,
+    ...strict.rules,
   },
-  rules: {},
 };

packages/eslint-config-airbnb-base/index.js

@@ -4,14 +4,14 @@ module.exports = {
     './rules/errors',
     './rules/node',
     './rules/style',
-    './rules/variables'
+    './rules/variables',
   ].map(require.resolve),
   env: {
     browser: true,
     node: true,
     amd: false,
     mocha: false,
-    jasmine: false
+    jasmine: false,
   },
   rules: {
     'comma-dangle': ['error', 'never'],
@@ -30,5 +30,5 @@ module.exports = {
     'no-var': 'off',
     'prefer-object-spread': 'off',
     strict: ['error', 'safe'],
-  }
+  },
 };

packages/eslint-config-airbnb-base/legacy.js

@@ -18,12 +18,11 @@
     "./package.json": "./package.json"
   },
   "scripts": {
-    "prelint": "eclint check $(git ls-files | xargs find 2> /dev/null | grep -vE 'node_modules|\\.git')",
-    "lint": "eslint --report-unused-disable-directives .",
+    "prelint": "eclint check \"**/*.js\"",
+    "lint": "eslint .",
     "pretests-only": "node ./test/requires",
     "tests-only": "babel-tape-runner ./test/test-*.js",
-    "prepublishOnly": "eslint-find-rules --unused && npm test && safe-publish-latest",
-    "prepublish": "not-in-publish || npm run prepublishOnly",
+    "prepublish": "not-in-publish || npm test",
     "pretest": "npm run --silent lint",
     "test": "npm run --silent tests-only",
     "pretravis": ":",
@@ -72,21 +71,22 @@
     "babel-preset-airbnb": "^4.5.0",
     "babel-tape-runner": "^3.0.0",
     "eclint": "^2.8.1",
-    "eslint": "^7.32.0 || ^8.2.0",
-    "eslint-find-rules": "^4.1.0",
+    "eslint": "^9.8.0",
     "eslint-plugin-import": "^2.30.0",
     "in-publish": "^2.0.1",
-    "safe-publish-latest": "^2.0.0",
-    "tape": "^5.9.0"
+    "safe-publish-latest": "^2.0.0"
   },
   "peerDependencies": {
-    "eslint": "^7.32.0 || ^8.2.0",
+    "eslint": "^9.8.0",
     "eslint-plugin-import": "^2.30.0"
   },
   "engines": {
     "node": "^10.12.0 || >=12.0.0"
   },
   "dependencies": {
-    "confusing-browser-globals": "^1.0.11"
+    "confusing-browser-globals": "^1.0.11",
+    "globals": "^15.8.0",
+    "@stylistic/eslint-plugin-js": "^2.4.0",
+    "tape": "^5.9.0"
   }
 }

packages/eslint-config-airbnb-base/package.json

@@ -97,7 +97,7 @@ module.exports = {
         'arrowFunctions',
         'functions',
         'methods',
-      ]
+      ],
     }],
 
     // disallow empty destructuring patterns
@@ -248,7 +248,7 @@ module.exports = {
         'response', // for Express responses
         '$scope', // for Angular 1 scopes
         'staticContext', // for ReactRouter context
-      ]
+      ],
     }],
 
     // disallow usage of __proto__ property
@@ -419,6 +419,6 @@ module.exports = {
 
     // require or disallow Yoda conditions
     // https://eslint.org/docs/rules/yoda
-    yoda: 'error'
-  }
+    yoda: 'error',
+  },
 };

packages/eslint-config-airbnb-base/rules/best-practices.js

@@ -185,5 +185,5 @@ module.exports = {
     // ensure that the results of typeof are compared against a valid string
     // https://eslint.org/docs/rules/valid-typeof
     'valid-typeof': ['error', { requireStringLiterals: true }],
-  }
+  },
 };

packages/eslint-config-airbnb-base/rules/errors.js

@@ -1,14 +1,14 @@
 module.exports = {
   env: {
-    es6: true
+    es6: true,
   },
   parserOptions: {
     ecmaVersion: 6,
     sourceType: 'module',
     ecmaFeatures: {
       generators: false,
-      objectLiteralDuplicateProperties: false
-    }
+      objectLiteralDuplicateProperties: false,
+    },
   },
 
   rules: {
@@ -73,7 +73,7 @@ module.exports = {
     // https://eslint.org/docs/rules/no-restricted-imports
     'no-restricted-imports': ['off', {
       paths: [],
-      patterns: []
+      patterns: [],
     }],
 
     // disallow to use this/super before super() calling in constructors.
@@ -180,6 +180,6 @@ module.exports = {
 
     // enforce spacing around the * in yield* expressions
     // https://eslint.org/docs/rules/yield-star-spacing
-    'yield-star-spacing': ['error', 'after']
-  }
+    'yield-star-spacing': ['error', 'after'],
+  },
 };

packages/eslint-config-airbnb-base/rules/es6.js

@@ -1,20 +1,20 @@
 module.exports = {
   env: {
-    es6: true
+    es6: true,
   },
   parserOptions: {
     ecmaVersion: 6,
-    sourceType: 'module'
+    sourceType: 'module',
   },
   plugins: [
-    'import'
+    'import',
   ],
 
   settings: {
     'import/resolver': {
       node: {
-        extensions: ['.mjs', '.js', '.json']
-      }
+        extensions: ['.mjs', '.js', '.json'],
+      },
     },
     'import/extensions': [
       '.js',
@@ -91,7 +91,7 @@ module.exports = {
         '**/protractor.conf.js', // protractor config
         '**/protractor.conf.*.js', // protractor config
         '**/karma.conf.js', // karma config
-        '**/.eslintrc.js' // eslint config
+        '**/.eslintrc.js', // eslint config
       ],
       optionalDependencies: false,
     }],
@@ -260,8 +260,9 @@ module.exports = {
       unusedExports: true,
     }],
 
-    // Reports the use of import declarations with CommonJS exports in any module except for the main module.
-    // https://github.com/import-js/eslint-plugin-import/blob/1012eb951767279ce3b540a4ec4f29236104bb5b/docs/rules/no-import-module-exports.md
+    // Reports the use of import declarations with CommonJS exports in any module
+    // except for the main module.
+    // https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-import-module-exports.md
     'import/no-import-module-exports': ['error', {
       exceptions: [],
     }],