chore(airbyte-server): expose connector config updated in check output (#18030)

Author: gosusnp

airbyte-api/server-api/src/main/openapi/config.yaml

@@ -6803,6 +6803,8 @@ paths:
                   status:
                     type: string
                     enum: [succeeded, failed]
+                  connectorConfigurationUpdated:
+                    type: boolean
                   message:
                     type: string
                   failureReason:

airbyte-server/src/main/kotlin/io/airbyte/server/apis/controllers/CommandApiController.kt

@@ -111,6 +111,7 @@ class CommandApiController(
         id(checkCommandOutputRequest.id)
         output?.let {
           status(it.status.toApi())
+          connectorConfigurationUpdated(it.connectorConfigUpdated)
           message(it.message)
           failureReason(apiPojoConverters.failureReasonToApi(it.failureReason))
           logs(output.logs?.toApi())

airbyte-server/src/main/kotlin/io/airbyte/server/services/CommandService.kt

@@ -679,6 +679,7 @@ class CommandService(
     }?.let { jobOutput ->
       return CheckJobOutput(
         status = jobOutput.checkConnection.status,
+        connectorConfigUpdated = jobOutput.connectorConfigurationUpdated ?: false,
         message = jobOutput.checkConnection?.message,
         failureReason = jobOutput.failureReason,
         logs = if (withLogs) getJobLogs(commandId) else null,
@@ -702,6 +703,7 @@ class CommandService(
 
   data class CheckJobOutput(
     val status: StandardCheckConnectionOutput.Status,
+    val connectorConfigUpdated: Boolean,
     val message: String?,
     val failureReason: FailureReason?,
     val logs: JobLogs?,

airbyte-server/src/test/kotlin/io/airbyte/server/apis/controllers/CommandApiControllerTest.kt

@@ -148,12 +148,14 @@ class CommandApiControllerTest {
     every { commandService.getCheckJobOutput(TEST_COMMAND_ID, any()) } returns
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.SUCCEEDED,
+        connectorConfigUpdated = false,
         message = "",
         failureReason = null,
         logs = null,
       )
 
     val output = controller.getCheckCommandOutput(CheckCommandOutputRequest().id(TEST_COMMAND_ID))
+    assertEquals(false, output.connectorConfigurationUpdated)
     assertEquals(TEST_COMMAND_ID, output.id)
     assertEquals(CheckCommandOutputResponse.StatusEnum.SUCCEEDED, output.status)
     assertEquals(null, output.logs)
@@ -166,6 +168,7 @@ class CommandApiControllerTest {
     every { commandService.getCheckJobOutput(TEST_COMMAND_ID, any()) } returns
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.FAILED,
+        connectorConfigUpdated = false,
         message = message,
         failureReason = null,
         logs = null,
@@ -175,6 +178,7 @@ class CommandApiControllerTest {
     assertEquals(
       CheckCommandOutputResponse()
         .id(TEST_COMMAND_ID)
+        .connectorConfigurationUpdated(false)
         .status(CheckCommandOutputResponse.StatusEnum.FAILED)
         .message(message),
       output,
@@ -187,6 +191,7 @@ class CommandApiControllerTest {
     every { commandService.getCheckJobOutput(TEST_COMMAND_ID, any()) } returns
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.FAILED,
+        connectorConfigUpdated = true,
         message = "",
         failureReason =
           FailureReason()
@@ -202,6 +207,7 @@ class CommandApiControllerTest {
 
     val output = controller.getCheckCommandOutput(CheckCommandOutputRequest().id(TEST_COMMAND_ID))
     assertEquals(TEST_COMMAND_ID, output.id)
+    assertEquals(true, output.connectorConfigurationUpdated)
     assertEquals(CheckCommandOutputResponse.StatusEnum.FAILED, output.status)
     assertEquals(
       ApiFailureReason()
@@ -576,6 +582,7 @@ class CommandApiControllerTest {
     every { commandService.getCheckJobOutput(TEST_COMMAND_ID, withLogs = true) } returns
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.SUCCEEDED,
+        connectorConfigUpdated = false,
         message = "",
         failureReason = null,
         logs = CommandService.JobLogs.createStructuredLogs(logEvents),
@@ -602,6 +609,7 @@ class CommandApiControllerTest {
     every { commandService.getCheckJobOutput(TEST_COMMAND_ID, withLogs = true) } returns
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.SUCCEEDED,
+        connectorConfigUpdated = false,
         message = "",
         failureReason = null,
         logs = CommandService.JobLogs.createFormattedLogs(logLines),
@@ -621,6 +629,7 @@ class CommandApiControllerTest {
     every { commandService.getCheckJobOutput(TEST_COMMAND_ID, withLogs = false) } returns
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.SUCCEEDED,
+        connectorConfigUpdated = false,
         message = "",
         failureReason = null,
         logs = null,

airbyte-server/src/test/kotlin/io/airbyte/server/services/CommandServiceTest.kt

@@ -370,6 +370,7 @@ class CommandServiceTest {
     val connectorOutput =
       ConnectorJobOutput()
         .withOutputType(OutputType.CHECK_CONNECTION)
+        .withConnectorConfigurationUpdated(true)
         .withCheckConnection(
           StandardCheckConnectionOutput()
             .withStatus(StandardCheckConnectionOutput.Status.SUCCEEDED)
@@ -381,6 +382,7 @@ class CommandServiceTest {
     val expectedOutput =
       CommandService.CheckJobOutput(
         status = StandardCheckConnectionOutput.Status.SUCCEEDED,
+        connectorConfigUpdated = true,
         message = "Success",
         failureReason = null,
         logs = null,