🐛 Fix Helm Charts: remove leaking database credentials from airbyte's config map #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
Hi, we've decided to stop accepting PRs in this repo, so we can focus on supporting our connector contributors. I'm going to close this issue. We appreciate your work here. Please feel free to post an issue in https://github.com/airbytehq/airbyte. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
airbyte_envconfig map inairbytecharts includes database credentials, which should be a secret instead.How
Remove the credentials from the
airbyte_envconfig map since these secrets are not referred to anywhere through this config map.Can this PR be safely reverted and rolled back?