apply suggestion

aaronsteers · web-flow · commit 4394ea2d136c · 2025-05-16T14:06:37.000-07:00
diff --git a/airbyte_cdk/cli/airbyte_cdk/_secrets.py b/airbyte_cdk/cli/airbyte_cdk/_secrets.py
@@ -50,6 +50,9 @@
 )
 
 GCP_PROJECT_ID: str = os.environ.get("GCP_PROJECT_ID", "") or "dataline-integration-testing"
+# We put the `or` outside the `get()` because we want the `GCP_PROJECT_ID`
+# value to be ignored if it contains an empty string, such as in CI where the
+# workflow might set it to a value that is itself actually missing or unset.
 """The GCP project ID to use for fetching integration test secrets."""
 
 CONNECTOR_LABEL = "connector"

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@`
`50`	`50`	`)`
`51`	`51`
`52`	`52`	`GCP_PROJECT_ID: str = os.environ.get("GCP_PROJECT_ID", "") or "dataline-integration-testing"`
	`53`	+# We put the `or` outside the `get()` because we want the `GCP_PROJECT_ID`
	`54`	`+# value to be ignored if it contains an empty string, such as in CI where the`
	`55`	`+# workflow might set it to a value that is itself actually missing or unset.`
`53`	`56`	`"""The GCP project ID to use for fetching integration test secrets."""`
`54`	`57`
`55`	`58`	`CONNECTOR_LABEL = "connector"`