refactor!: remove hogan.js (#6378)

BREAKING CHANGE : Hogan.js and raw HTML templates will no longer work. `bindEvent` also removed.

---------

Co-authored-by: Haroen Viaene <[email protected]>

Author: aymeric-giraudet

babel.config.js

@@ -87,6 +87,10 @@ module.exports = (api) => {
 
             // false positive (spread)
             'Object.getOwnPropertyDescriptors',
+
+            // @TODO: see when we remove IE11 support
+            'Object.fromEntries',
+            'Object.entries',
           ];
           if (defaultShouldInject && !exclude.includes(name)) {
             throw new Error(

packages/algolia-experiences/src/render.tsx

@@ -293,7 +293,7 @@ function blockToWidget(child: Block, container: HTMLElement): Widget[] {
     return [
       panel<typeof widgets['ais.refinementList']>({
         templates: {
-          header,
+          header: () => header,
           collapseButtonText: ({ collapsed }) => (
             // @TODO: put this style in a stylesheet
             <span style="cursor: pointer">{collapsed ? '+' : '-'}</span>

packages/instantsearch.js/package.json

@@ -29,10 +29,8 @@
     "@algolia/events": "^4.0.1",
     "@types/dom-speech-recognition": "^0.0.1",
     "@types/google.maps": "^3.55.12",
-    "@types/hogan.js": "^3.0.0",
     "@types/qs": "^6.5.3",
     "algoliasearch-helper": "3.22.5",
-    "hogan.js": "^3.0.2",
     "htm": "^3.0.0",
     "instantsearch-ui-components": "0.9.0",
     "preact": "^10.10.0",

packages/instantsearch.js/src/__tests__/common-widgets.test.tsx

@@ -418,7 +418,7 @@ const testSetups: TestSetupsMap<TestSuites> = {
           container: document.body.appendChild(document.createElement('div')),
           ...widgetParams,
           templates: {
-            labelText: label,
+            labelText: label ? () => label : undefined,
           },
         }),
       ])

packages/instantsearch.js/src/components/Answers/__tests__/Answers-test.tsx

@@ -23,9 +23,9 @@ const defaultProps: AnswersProps = {
   },
   templateProps: {
     templates: {
-      header: 'header',
-      loader: 'loader',
-      item: 'item',
+      header: () => 'header',
+      loader: () => 'loader',
+      item: () => 'item',
     },
   },
 };

packages/instantsearch.js/src/components/Breadcrumb/__tests__/Breadcrumb-test.tsx

@@ -28,7 +28,6 @@ const defaultProps: BreadcrumbProps = {
   templateProps: prepareTemplateProps({
     defaultTemplates,
     templates: {},
-    templatesConfig: {},
   }),
 };
 

packages/instantsearch.js/src/components/GeoSearchControls/__tests__/GeoSearchControls-test.tsx

@@ -24,13 +24,12 @@ describe('GeoSearchControls', () => {
 
   const templateProps = prepareTemplateProps({
     defaultTemplates: {
-      toggle: 'toggle',
-      redo: 'redo',
-      reset: 'reset',
-      HTMLMarker: '',
+      toggle: () => 'toggle',
+      redo: () => 'redo',
+      reset: () => 'reset',
+      HTMLMarker: () => '',
     },
     templates: {},
-    templatesConfig: {},
   });
 
   const defaultProps = {

packages/instantsearch.js/src/components/InfiniteHits/InfiniteHits.tsx

@@ -81,7 +81,6 @@ const InfiniteHits = ({
   results,
   hits,
   insights,
-  bindEvent,
   sendEvent,
   hasShowPrevious,
   showPrevious,
@@ -188,7 +187,6 @@ const InfiniteHits = ({
                 return index;
               },
             }}
-            bindEvent={bindEvent}
             sendEvent={sendEvent}
           />
         ))}

packages/instantsearch.js/src/components/InfiniteHits/__tests__/InfiniteHits-test.tsx

@@ -61,10 +61,10 @@ describe('InfiniteHits', () => {
         isLastPage: false,
         templateProps: {
           templates: {
-            empty: 'empty',
-            showPreviousText: 'showPreviousText',
-            showMoreText: 'showMoreText',
-            item: 'item',
+            empty: () => 'empty',
+            showPreviousText: () => 'showPreviousText',
+            showMoreText: () => 'showMoreText',
+            item: () => 'item',
           },
         },
         cssClasses,
@@ -101,10 +101,10 @@ describe('InfiniteHits', () => {
         isLastPage: true,
         templateProps: {
           templates: {
-            empty: 'empty',
-            showPreviousText: 'showPreviousText',
-            showMoreText: 'showMoreText',
-            item: 'item',
+            empty: () => 'empty',
+            showPreviousText: () => 'showPreviousText',
+            showMoreText: () => 'showMoreText',
+            item: () => 'item',
           },
         },
         cssClasses,
@@ -130,10 +130,10 @@ describe('InfiniteHits', () => {
         isLastPage: false,
         templateProps: {
           templates: {
-            empty: 'empty',
-            showPreviousText: 'showPreviousText',
-            showMoreText: 'showMoreText',
-            item: 'item',
+            empty: () => 'empty',
+            showPreviousText: () => 'showPreviousText',
+            showMoreText: () => 'showMoreText',
+            item: () => 'item',
           },
         },
         cssClasses,
@@ -159,10 +159,10 @@ describe('InfiniteHits', () => {
         isLastPage: true,
         templateProps: {
           templates: {
-            empty: 'empty',
-            showPreviousText: 'showPreviousText',
-            showMoreText: 'showMoreText',
-            item: 'item',
+            empty: () => 'empty',
+            showPreviousText: () => 'showPreviousText',
+            showMoreText: () => 'showMoreText',
+            item: () => 'item',
           },
         },
         cssClasses,
@@ -199,10 +199,10 @@ describe('InfiniteHits', () => {
         isLastPage: false,
         templateProps: {
           templates: {
-            empty: 'empty',
-            showPreviousText: 'showPreviousText',
-            showMoreText: 'showMoreText',
-            item: 'item',
+            empty: () => 'empty',
+            showPreviousText: () => 'showPreviousText',
+            showMoreText: () => 'showMoreText',
+            item: () => 'item',
           },
         },
         cssClasses,
@@ -244,10 +244,10 @@ describe('InfiniteHits', () => {
         isLastPage: true,
         templateProps: {
           templates: {
-            empty: 'empty',
-            showPreviousText: 'showPreviousText',
-            showMoreText: 'showMoreText',
-            item: 'item',
+            empty: () => 'empty',
+            showPreviousText: () => 'showPreviousText',
+            showMoreText: () => 'showMoreText',
+            item: () => 'item',
           },
         },
         cssClasses,

packages/instantsearch.js/src/components/InfiniteHits/__tests__/InfiniteHits.test.tsx

@@ -82,7 +82,6 @@ describe('InfiniteHits', () => {
             return '';
           },
         },
-        templatesConfig: {},
         templates: {},
       }),
       ...props,