Switch to CongestionFee so that 0 is common case

Author: jannotti

agreement/msgp_gen.go

@@ -225,9 +225,9 @@ func verifyProposer(p unauthenticatedProposal, ledger LedgerReader) error {
 	if err != nil {
 		return fmt.Errorf("failed to determine incentive eligibility %w", err)
 	}
-	if !eligible && p.ProposerPayout().Raw > 0 {
-		return fmt.Errorf("proposer payout (%d) for ineligible Proposer %v",
-			p.ProposerPayout().Raw, p.Proposer())
+	if !eligible && !p.ProposerPayout().IsZero() {
+		return fmt.Errorf("proposer payout (%s) for ineligible Proposer %v",
+			p.ProposerPayout(), p.Proposer())
 	}
 
 	var alpha crypto.Digest

agreement/proposal.go

@@ -574,7 +574,7 @@ type ConsensusParams struct {
 	EnableInnerClawbackWithoutSenderHolding bool
 
 	// CongestionFees enables header values that track Load and a running
-	// BaseFee that grows/shrinks when blocks are more/less than half full
+	// CongestionFee that grows/shrinks when blocks are more/less than half full
 	CongestionFees bool
 }
 

config/consensus.go

@@ -4733,8 +4733,8 @@
             "type": "integer",
             "x-go-type": "uint64"
           },
-          "base-fee": {
-            "description": "The current base transaction fee (not per byte) required for the txn to validate with the current congestion conditions.",
+          "congestion-fee": {
+            "description": "The current extra fee beyond min-fee required for the txn to validate with the current congestion conditions.",
             "type": "integer",
             "x-go-type": "uint64"
           }

daemon/algod/api/algod.oas2.json

@@ -922,8 +922,8 @@
             "schema": {
               "description": "TransactionParams contains the parameters that help a client construct\na new transaction.",
               "properties": {
-                "base-fee": {
-                  "description": "The current base transaction fee (not per byte) required for the txn to validate with the current congestion conditions.",
+                "congestion-fee": {
+                  "description": "The current extra fee beyond min-fee required for the txn to validate with the current congestion conditions.",
                   "type": "integer",
                   "x-go-type": "uint64"
                 },
@@ -7262,8 +7262,8 @@
                 "schema": {
                   "description": "TransactionParams contains the parameters that help a client construct\na new transaction.",
                   "properties": {
-                    "base-fee": {
-                      "description": "The current base transaction fee (not per byte) required for the txn to validate with the current congestion conditions.",
+                    "congestion-fee": {
+                      "description": "The current extra fee beyond min-fee required for the txn to validate with the current congestion conditions.",
                       "type": "integer",
                       "x-go-type": "uint64"
                     },