Fix: Correct GeneratedAccountsMnemonics Check (#5274)

AlgoAxel · web-flow · commit 9fc615830193 · 2023-04-28T09:44:05.000-04:00
diff --git a/cmd/pingpong/runCmd.go b/cmd/pingpong/runCmd.go
@@ -438,7 +438,9 @@ var runCmd = &cobra.Command{
 			cfg.GeneratedAccountSampleMethod = generatedAccountSampleMethod
 		}
 		// check if numAccounts is greater than the length of the mnemonic list, if provided
-		if cfg.DeterministicKeys && cfg.NumPartAccounts > uint32(len(cfg.GeneratedAccountsMnemonics)) {
+		if cfg.DeterministicKeys &&
+			len(cfg.GeneratedAccountsMnemonics) > 0 &&
+			cfg.NumPartAccounts > uint32(len(cfg.GeneratedAccountsMnemonics)) {
 			reportErrorf("numAccounts is greater than number of account mnemonics provided")
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,9 @@ var runCmd = &cobra.Command{`
`438`	`438`	`cfg.GeneratedAccountSampleMethod = generatedAccountSampleMethod`
`439`	`439`	`}`
`440`	`440`	`// check if numAccounts is greater than the length of the mnemonic list, if provided`
`441`		`- if cfg.DeterministicKeys && cfg.NumPartAccounts > uint32(len(cfg.GeneratedAccountsMnemonics)) {`
	`441`	`+ if cfg.DeterministicKeys &&`
	`442`	`+ len(cfg.GeneratedAccountsMnemonics) > 0 &&`
	`443`	`+ cfg.NumPartAccounts > uint32(len(cfg.GeneratedAccountsMnemonics)) {`
`442`	`444`	`reportErrorf("numAccounts is greater than number of account mnemonics provided")`
`443`	`445`	`}`
`444`	`446`