Merge pull request #11 from aliyun/features/fix

bruceding · web-flow · commit afcd6a2c01c9 · 2024-04-10T14:45:33.000+08:00
[fix]: return event_time in getfeatures result; support int key input…
diff --git a/dao/feature_view_tablestore_dao.go b/dao/feature_view_tablestore_dao.go
@@ -71,7 +71,7 @@ func (d *FeatureViewTableStoreDao) GetFeatures(keys []interface{}, selectFields
 					if v, ok := key.(int64); ok {
 						pkToGet.AddPrimaryKeyColumn(d.primaryKeyField, v)
 					} else {
-						s, _ := key.(string)
+						s := fmt.Sprintf("%v", key)
 						i, _ := strconv.ParseInt(s, 10, 64)
 						pkToGet.AddPrimaryKeyColumn(d.primaryKeyField, i)
 					}
diff --git a/domain/base_feature_view.go b/domain/base_feature_view.go
@@ -28,6 +28,7 @@ func NewBaseFeatureView(view *api.FeatureView, p *Project, entity *FeatureEntity
 	for _, field := range view.Fields {
 		if field.IsEventTime {
 			featureView.eventTimeField = *field
+			featureView.featureFields = append(featureView.featureFields, field.Name)
 		} else if field.IsPartition {
 			continue
 		} else if field.IsPrimaryKey {

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ func (d *FeatureViewTableStoreDao) GetFeatures(keys []interface{}, selectFields`
`71`	`71`	`if v, ok := key.(int64); ok {`
`72`	`72`	`pkToGet.AddPrimaryKeyColumn(d.primaryKeyField, v)`
`73`	`73`	`} else {`
`74`		`- s, _ := key.(string)`
	`74`	`+ s := fmt.Sprintf("%v", key)`
`75`	`75`	`i, _ := strconv.ParseInt(s, 10, 64)`
`76`	`76`	`pkToGet.AddPrimaryKeyColumn(d.primaryKeyField, i)`
`77`	`77`	`}`