-
Notifications
You must be signed in to change notification settings - Fork 491
[feat] Introduced helper iterator for CallFrame #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, left a few suggestions
also we need an fn iter on CallFrame that then returns CallFrameIter::new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
one more nit re unwrap
@mattsse, sorry for the delay. For some reason, your review didn't drop a notification. |
|
@developeruche would you still be on to drive this PR to the finish line? thank you! |
Yeah, I am! Still waiting on a review |
Motivation
Fixes #2775
Solution
Introduced a New Iterator type;
CallFrameIter, also enabling a utility method for skipping children.PR Checklist