Skip to content

Conversation

@developeruche
Copy link
Contributor

Motivation

Fixes #2775

Solution

Introduced a New Iterator type;
CallFrameIter, also enabling a utility method for skipping children.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, left a few suggestions

also we need an fn iter on CallFrame that then returns CallFrameIter::new

@github-project-automation github-project-automation bot moved this to In Progress in Alloy Aug 18, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

one more nit re unwrap

@developeruche
Copy link
Contributor Author

great

one more nit re unwrap

@mattsse, sorry for the delay. For some reason, your review didn't drop a notification.

@grandizzy
Copy link
Contributor

@developeruche would you still be on to drive this PR to the finish line? thank you!

@developeruche
Copy link
Contributor Author

@developeruche would you still be on to drive this PR to the finish line? thank you!

Yeah, I am! Still waiting on a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[Feature] Add helper iterator for Callframe

3 participants