-
Notifications
You must be signed in to change notification settings - Fork 29
build(deps): Bump Riverpod to 2.6.1 #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| exec: | | ||
| dart fix --apply lib | ||
| dart run custom_lint --fix | ||
| description: Run dart and custom_lint fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added custom_lint --fix to run.
| ref | ||
| ..listen(appLifecycleProvider, (prev, next) { | ||
| logger.finest('AppLifecycleState: prev: $prev, next: $next'); | ||
| }) | ||
| ..listen(localesProvider, (prev, next) { | ||
| logger.finest('Locales: prev: $prev, next: $next'); | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listentoref.listenforappLifecycleProviderandlocalesProvider` to make sure they are being monitored.
|
|
||
| part 'app_lifecycle_provider.g.dart'; | ||
|
|
||
| @riverpod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed keepAlive:true since it only needs to survive where I want to monitor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 23.75% 23.75%
=======================================
Files 13 13
Lines 160 160
=======================================
Hits 38 38
Misses 122 122
Continue to review full report in Codecov by Sentry.
|
| @@ -1,4 +1,4 @@ | |||
| export 'app_lifecycle_state_provider.dart'; | |||
| export 'app_lifecycle_provider.dart'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the name of Notifier to AppLifecycleState because it conflicts.
naipaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 What's Done
✍️ What's Not Done
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Pre-launch Checklist