Skip to content

Conversation

@riscait
Copy link
Member

@riscait riscait commented Oct 23, 2024

🙌 What's Done

  • Change NameRef to Ref in provider argument

✍️ What's Not Done

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Comment on lines +41 to +44
exec: |
dart fix --apply lib
dart run custom_lint --fix
description: Run dart and custom_lint fixes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added custom_lint --fix to run.

Comment on lines +22 to +28
ref
..listen(appLifecycleProvider, (prev, next) {
logger.finest('AppLifecycleState: prev: $prev, next: $next');
})
..listen(localesProvider, (prev, next) {
logger.finest('Locales: prev: $prev, next: $next');
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listentoref.listenforappLifecycleProviderandlocalesProvider` to make sure they are being monitored.


part 'app_lifecycle_provider.g.dart';

@riverpod
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed keepAlive:true since it only needs to survive where I want to monitor.

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (a6e5f04) to head (3c2ef9f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           
Files with missing lines Coverage Δ
...pages/riverpod_example_page/util/dio_provider.dart 0.00% <ø> (ø)
...il/network_connectivity/connectivity_provider.dart 100.00% <ø> (ø)
...ib/util/providers/shared_preferences_provider.dart 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e5f04...3c2ef9f. Read the comment docs.

@@ -1,4 +1,4 @@
export 'app_lifecycle_state_provider.dart';
export 'app_lifecycle_provider.dart';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the name of Notifier to AppLifecycleState because it conflicts.

@riscait riscait marked this pull request as ready for review October 23, 2024 13:50
@riscait riscait requested a review from a team as a code owner October 23, 2024 13:50
@riscait riscait requested review from naipaka and removed request for a team October 23, 2024 13:50
@riscait riscait changed the title refactor: Bump Riverpod to 2.6.1 build(deps): Bump Riverpod to 2.6.1 Oct 23, 2024
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for the update!

@riscait riscait merged commit d47fe82 into main Oct 24, 2024
9 checks passed
@riscait riscait deleted the bump-riverpod-2.6.1 branch October 24, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants