Skip to content

Conversation

@riscait
Copy link
Member

@riscait riscait commented Oct 23, 2024

🙌 What's Done

  • Flutter to 3.24.3
  • Dart to 3.5.3

✍️ What's Not Done

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@riscait riscait requested a review from a team as a code owner October 23, 2024 14:08
@riscait riscait requested review from boywithdv and removed request for a team October 23, 2024 14:08
@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (f55d2c5) to head (93cc22e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55d2c5...93cc22e. Read the comment docs.

@riscait
Copy link
Member Author

riscait commented Oct 23, 2024

Depends on #506 because of CustomLint.

Copy link
Contributor

@boywithdv boywithdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait enabled auto-merge (squash) October 24, 2024 00:31
@riscait riscait merged commit c922686 into main Oct 24, 2024
8 checks passed
@riscait riscait deleted the flutter-3.24.3 branch October 24, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants