Skip to content

Conversation

@naipaka
Copy link
Contributor

@naipaka naipaka commented Oct 29, 2024

🙌 What's Done

  • Add 'slang:watch' script to melos

✍️ What's Not Done

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Comment on lines -57 to -65
slang:
run: dart run slang
exec:
concurrency: 1
description: Run generate translation code.
packageFilters:
dirExists: lib
dependsOn: slang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched the positions because it seemed easier to read with gen and slang grouped separately!

@naipaka naipaka marked this pull request as ready for review October 29, 2024 09:59
@naipaka naipaka requested a review from a team as a code owner October 29, 2024 09:59
@naipaka naipaka requested review from boywithdv and removed request for a team October 29, 2024 09:59
@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (c922686) to head (6ef73f0).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011596e...6ef73f0. Read the comment docs.

@naipaka naipaka changed the title refactor: Add 'slang:watch' script to melos chore: Add 'slang:watch' script to melos Oct 29, 2024
@naipaka naipaka requested a review from riscait October 29, 2024 09:59
Copy link
Contributor

@boywithdv boywithdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding slang watch ! 🚀

Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the additions and improvements!

@naipaka naipaka merged commit e02e8b4 into main Oct 29, 2024
8 checks passed
@naipaka naipaka deleted the add-melos-command-for-slang-watch branch October 29, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants