Skip to content

Commit deb854d

Browse files
committed
fix(submissions): make status checks for 'approved' and 'submitted' case-insensitive
1 parent ba67d55 commit deb854d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

app/db/crud.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def submit_task(db: Session, mentee_id: int, task_id: int, reference_link: str,
2727
task_no=task.task_no,
2828
reference_link=reference_link,
2929
submitted_at=date.today(),
30-
status="submitted",
30+
status="submitted".lower(),
3131
start_date=start_date,
3232
)
3333

@@ -40,10 +40,10 @@ def approve_submission(db: Session, submission_id: int, mentor_feedback: str, st
4040
sub = db.query(models.Submission).filter_by(id=submission_id).first()
4141
if not sub:
4242
return None
43-
44-
sub.status = status
43+
normalized_status = status.strip().lower()
44+
sub.status = normalized_status
4545
sub.mentor_feedback = mentor_feedback
46-
if status == "approved":
46+
if normalized_status == "approved":
4747
sub.approved_at = date.today()
4848

4949
db.commit()
@@ -63,7 +63,7 @@ def get_leaderboard_data(db: Session, track_id: int):
6363
)
6464
.join(models.Submission, models.Submission.mentee_id == models.User.id)
6565
.join(models.Task, models.Submission.task_id == models.Task.id)
66-
.filter(models.Submission.status == "approved")
66+
.filter(func.lower(models.Submission.status) == "approved")
6767
.filter(models.Task.track_id == track_id)
6868
.group_by(models.User.id)
6969
.order_by(func.sum(models.Task.points).desc())

0 commit comments

Comments
 (0)