Feature Request: Remove the @amplitude/analytics-react-native dependency with async storage and allow a custom storage implementation

[sebastian-herrera-itti]

Summary

In @amplitude/analytics-react-native sdk, consider making @react-native-async-storage/async-storage an optional peer dependency instead of a required dependency. This would allow developers to provide their own storage implementation, such as react-native-mmkv or expo-sqlite/kv-store, without being forced to include AsyncStorage. This change would reduce APK size and avoid maintaining multiple local data sources.

Motivations

The @amplitude/analytics-react-native SDK has @react-native-async-storage/async-storage as a required dependency. This forces us to include an additional local data source, even though we are already using mmkv for persistent local storage. It also adds unnecessary weight to the APK.

[martinezguillaume]

Another argument : It can lead to error like this :

Your project contains duplicate native module dependencies, which should be de-duplicated.
Native builds may only contain one version of any given native module, and having multiple versions of a single Native module installed may lead to unexpected build errors.
Found duplicates for @react-native-async-storage/async-storage:
  ├─ @react-native-async-storage/async-storage@2.2.0 (at: node_modules/@react-native-async-storage/async-storage)
  └─ @react-native-async-storage/async-storage@1.24.0 (at: node_modules/@amplitude/analytics-react-native/node_modules/@react-native-async-storage/async-storage)

Similar issue

[haswalt]

As @martinezguillaume shows this is also a big issue with the version of async-storage. In one of my products we're using a newer version of async-storage and it concerns us that an older version with potential security issues is forced into our apk.