fix(vite-plugin-angular): resolve tsconfig dynamically at the correct place #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brandonroberts
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Originally in #1892 I've put the resolving of the dynamic tsconfig in
configResolvedthinking it'll run after the nx vite pluginconfigResolvedbecause their plugin is configured as "pre".But no, the analog vite plugin runs before and because of that the first compilation is ignoring the dynamic value and because of that the loading times are slower.
What is the new behavior?
Moved it to the
performCompilationfunction, which definitally runs after nx has set the env variable which is needed to resovle the dynamic tsconfig.Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?